Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-17559: Fix the flaky RemoteLogOffsetReader#testTaskQueueFullAndCancelTask #17214

Merged
merged 3 commits into from
Sep 18, 2024
Merged

KAFKA-17559: Fix the flaky RemoteLogOffsetReader#testTaskQueueFullAndCancelTask #17214

merged 3 commits into from
Sep 18, 2024

Conversation

kamalcph
Copy link
Collaborator

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@kamalcph kamalcph mentioned this pull request Sep 17, 2024
Merged
3 tasks
mumrah
mumrah approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@mumrah mumrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a build perspective. I'll let others comment on the nature of the fix.

I just re-ran the tests for a third time. If this run passes, let's merge it and monitor this test on trunk (assuming another LGTM)

satishd
satishd reviewed Sep 18, 2024
View reviewed changes
Copy link
Member

@satishd satishd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kamalcph for the PR, left a minor comment.

core/src/test/java/kafka/log/remote/RemoteLogOffsetReaderTest.java Outdated Show resolved Hide resolved
@satishd satishd merged commit 77e9526 into apache:trunk Sep 18, 2024
8 of 9 checks passed
@kamalcph kamalcph deleted the KAFKA-17559 branch September 19, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mumrah mumrah mumrah approved these changes

@satishd satishd satishd approved these changes

@showuon showuon showuon approved these changes

@chia7712 chia7712 Awaiting requested review from chia7712

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kamalcph @mumrah @satishd @showuon