Skip to content

Commit

Permalink
Add merge to ShellCommand properties in config
Browse files Browse the repository at this point in the history
Signed-off-by: Stoica-Marcu Floris-Andrei <[email protected]>
  • Loading branch information
SMFloris authored and thaJeztah committed Apr 8, 2022
1 parent fbea85d commit cff702d
Show file tree
Hide file tree
Showing 2 changed files with 57 additions and 3 deletions.
7 changes: 4 additions & 3 deletions cli/compose/loader/merge.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ func mergeServices(base, override []types.ServiceConfig) ([]types.ServiceConfig,
reflect.TypeOf([]types.ServiceConfigObjConfig{}): mergeSlice(toServiceConfigObjConfigsMap, toSServiceConfigObjConfigsSlice),
reflect.TypeOf(&types.UlimitsConfig{}): mergeUlimitsConfig,
reflect.TypeOf([]types.ServiceVolumeConfig{}): mergeSlice(toServiceVolumeConfigsMap, toServiceVolumeConfigsSlice),
reflect.TypeOf(types.ShellCommand{}): mergeShellCommand,
reflect.TypeOf(&types.ServiceNetworkConfig{}): mergeServiceNetworkConfig,
},
}
Expand Down Expand Up @@ -235,9 +236,9 @@ func mergeUlimitsConfig(dst, src reflect.Value) error {
}

//nolint: unparam
func mergeServiceVolumeConfig(dst, src reflect.Value) error {
if dst.Elem().FieldByName("target").String() == src.Elem().FieldByName("target").String() {
dst.Set(src.Elem())
func mergeShellCommand(dst, src reflect.Value) error {
if src.Len() != 0 {
dst.Set(src)
}
return nil
}
Expand Down
53 changes: 53 additions & 0 deletions cli/compose/loader/merge_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1017,6 +1017,59 @@ func TestLoadMultipleNetworks(t *testing.T) {
}, config)
}

func TestLoadMultipleServiceCommands(t *testing.T) {
base := map[string]interface{}{
"version": "3.7",
"services": map[string]interface{}{
"foo": map[string]interface{}{
"image": "baz",
"command": "foo bar",
},
},
"volumes": map[string]interface{}{},
"networks": map[string]interface{}{},
"secrets": map[string]interface{}{},
"configs": map[string]interface{}{},
}
override := map[string]interface{}{
"version": "3.7",
"services": map[string]interface{}{
"foo": map[string]interface{}{
"image": "baz",
"command": "foo baz",
},
},
"volumes": map[string]interface{}{},
"networks": map[string]interface{}{},
"secrets": map[string]interface{}{},
"configs": map[string]interface{}{},
}
configDetails := types.ConfigDetails{
ConfigFiles: []types.ConfigFile{
{Filename: "base.yml", Config: base},
{Filename: "override.yml", Config: override},
},
}
config, err := Load(configDetails)
assert.NilError(t, err)
assert.DeepEqual(t, &types.Config{
Filename: "base.yml",
Version: "3.7",
Services: []types.ServiceConfig{
{
Name: "foo",
Image: "baz",
Command: types.ShellCommand{"foo", "baz"},
Environment: types.MappingWithEquals{},
},
},
Volumes: map[string]types.VolumeConfig{},
Secrets: map[string]types.SecretConfig{},
Configs: map[string]types.ConfigObjConfig{},
Networks: map[string]types.NetworkConfig{},
}, config)
}

func TestLoadMultipleServiceVolumes(t *testing.T) {
base := map[string]interface{}{
"version": "3.7",
Expand Down

0 comments on commit cff702d

Please sign in to comment.