Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(spanner): Add ARRAY keywords to keywords #10079

Merged
merged 6 commits into from
May 15, 2024
+169 −0
Merged

fix(spanner): Add ARRAY keywords to keywords #10079

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7814237
fix(spanner): Add ARRAY keywords to keywords
kai5263499 May 1, 2024
47e6be8
Merge branch 'main' into add_array_functions_to_keywords
harshachinta May 6, 2024
a8294bf
Merge branch 'main' into add_array_functions_to_keywords
harshachinta May 7, 2024
52f4601
Merge branch 'main' into add_array_functions_to_keywords
harshachinta May 14, 2024
8066109
add tests for array functions. removed ARRAY_FILTER as lambda express…
kai5263499 May 14, 2024
25991b0
Merge branch 'main' into add_array_functions_to_keywords
harshachinta May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add tests for array functions. removed ARRAY_FILTER as lambda express… 
…ions aren't supported
  • Loading branch information
@kai5263499
kai5263499 committed May 14, 2024
commit 80661099574d9b2a523218f36762db91f0bf8587
2 changes: 1 addition & 1 deletion spanner/spansql/keywords.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ var funcNames = []string{
// Array functions.
"ARRAY",
"ARRAY_CONCAT",
"ARRAY_FILTER", "ARRAY_FIRST", "ARRAY_INCLUDES", "ARRAY_INCLUDES_ALL", "ARRAY_INCLUDES_ANY", "ARRAY_LAST",
"ARRAY_FIRST", "ARRAY_INCLUDES", "ARRAY_INCLUDES_ALL", "ARRAY_INCLUDES_ANY", "ARRAY_LAST",
"ARRAY_LENGTH",
"ARRAY_MAX", "ARRAY_MIN", "ARRAY_REVERSE", "ARRAY_SLICE", "ARRAY_TRANSFORM",
"ARRAY_TO_STRING",
Expand Down
167 changes: 167 additions & 0 deletions spanner/spansql/parser_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1491,6 +1491,173 @@ func TestParseDDL(t *testing.T) {
Position: line(1),
},
}}},
{`ALTER TABLE products ADD COLUMN item ARRAY<STRING(MAX)> AS (ARRAY_INCLUDES(itemDetails, 'value1')) STORED`, &DDL{Filename: "filename", List: []DDLStmt{
&AlterTable{
Name: "products",
Alteration: AddColumn{Def: ColumnDef{
Name: "item",
Type: Type{Base: String, Array: true, Len: MaxLen},
Position: line(1),
Generated: Func{
Name: "ARRAY_INCLUDES",
Args: []Expr{ID("itemDetails"), StringLiteral("value1")},
},
}},
Position: line(1),
},
}}},
{`ALTER TABLE products ADD COLUMN item STRING(MAX) AS (ARRAY_MAX(itemDetails)) STORED`, &DDL{Filename: "filename", List: []DDLStmt{
&AlterTable{
Name: "products",
Alteration: AddColumn{Def: ColumnDef{
Name: "item",
Type: Type{Base: String, Array: false, Len: MaxLen},
Position: line(1),
Generated: Func{
Name: "ARRAY_MAX",
Args: []Expr{ID("itemDetails")},
},
}},
Position: line(1),
},
}}},
{`ALTER TABLE products ADD COLUMN item STRING(MAX) AS (ARRAY_MIN(itemDetails)) STORED`, &DDL{Filename: "filename", List: []DDLStmt{
&AlterTable{
Name: "products",
Alteration: AddColumn{Def: ColumnDef{
Name: "item",
Type: Type{Base: String, Array: false, Len: MaxLen},
Position: line(1),
Generated: Func{
Name: "ARRAY_MIN",
Args: []Expr{ID("itemDetails")},
},
}},
Position: line(1),
},
}}},
{`ALTER TABLE products ADD COLUMN item ARRAY<STRING(MAX)> AS (ARRAY_REVERSE(itemDetails)) STORED`, &DDL{Filename: "filename", List: []DDLStmt{
&AlterTable{
Name: "products",
Alteration: AddColumn{Def: ColumnDef{
Name: "item",
Type: Type{Base: String, Array: true, Len: MaxLen},
Position: line(1),
Generated: Func{
Name: "ARRAY_REVERSE",
Args: []Expr{ID("itemDetails")},
},
}},
Position: line(1),
},
}}},
{`ALTER TABLE products ADD COLUMN item ARRAY<STRING(MAX)> AS (ARRAY_SLICE(itemDetails, 1, 3)) STORED`, &DDL{Filename: "filename", List: []DDLStmt{
&AlterTable{
Name: "products",
Alteration: AddColumn{Def: ColumnDef{
Name: "item",
Type: Type{Base: String, Array: true, Len: MaxLen},
Position: line(1),
Generated: Func{
Name: "ARRAY_SLICE",
Args: []Expr{ID("itemDetails"), IntegerLiteral(1), IntegerLiteral(3)},
},
}},
Position: line(1),
},
}}},
{`ALTER TABLE products ADD COLUMN item ARRAY<STRING(MAX)> AS (ARRAY_TRANSFORM(itemDetails, 'value1')) STORED`, &DDL{Filename: "filename", List: []DDLStmt{
&AlterTable{
Name: "products",
Alteration: AddColumn{Def: ColumnDef{
Name: "item",
Type: Type{Base: String, Array: true, Len: MaxLen},
Position: line(1),
Generated: Func{
Name: "ARRAY_TRANSFORM",
Args: []Expr{ID("itemDetails"), StringLiteral("value1")},
},
}},
Position: line(1),
},
}}},
{`ALTER TABLE products ADD COLUMN item ARRAY<STRING(MAX)> AS (ARRAY_FIRST(itemDetails)) STORED`, &DDL{Filename: "filename", List: []DDLStmt{
&AlterTable{
Name: "products",
Alteration: AddColumn{Def: ColumnDef{
Name: "item",
Type: Type{Base: String, Array: true, Len: MaxLen},
Position: line(1),
Generated: Func{
Name: "ARRAY_FIRST",
Args: []Expr{ID("itemDetails")},
},
}},
Position: line(1),
},
}}},

{`ALTER TABLE products ADD COLUMN item ARRAY<STRING(MAX)> AS (ARRAY_INCLUDES(itemDetails, 'value1')) STORED`, &DDL{Filename: "filename", List: []DDLStmt{
&AlterTable{
Name: "products",
Alteration: AddColumn{Def: ColumnDef{
Name: "item",
Type: Type{Base: String, Array: true, Len: MaxLen},
Position: line(1),
Generated: Func{
Name: "ARRAY_INCLUDES",
Args: []Expr{ID("itemDetails"), StringLiteral("value1")},
},
}},
Position: line(1),
},
}}},

{`ALTER TABLE products ADD COLUMN item ARRAY<STRING(MAX)> AS (ARRAY_INCLUDES_ALL(itemDetails, ["1", "2"])) STORED`, &DDL{Filename: "filename", List: []DDLStmt{
&AlterTable{
Name: "products",
Alteration: AddColumn{Def: ColumnDef{
Name: "item",
Type: Type{Base: String, Array: true, Len: MaxLen},
Position: line(1),
Generated: Func{
Name: "ARRAY_INCLUDES_ALL",
Args: []Expr{ID("itemDetails"), Array{StringLiteral("1"), StringLiteral("2")}},
},
}},
Position: line(1),
},
}}},
{`ALTER TABLE products ADD COLUMN item ARRAY<STRING(MAX)> AS (ARRAY_INCLUDES_ANY(itemDetails, ["1", "2"])) STORED`, &DDL{Filename: "filename", List: []DDLStmt{
&AlterTable{
Name: "products",
Alteration: AddColumn{Def: ColumnDef{
Name: "item",
Type: Type{Base: String, Array: true, Len: MaxLen},
Position: line(1),
Generated: Func{
Name: "ARRAY_INCLUDES_ANY",
Args: []Expr{ID("itemDetails"), Array{StringLiteral("1"), StringLiteral("2")}},
},
}},
Position: line(1),
},
}}},
{`ALTER TABLE products ADD COLUMN item ARRAY<STRING(MAX)> AS (ARRAY_LAST(itemDetails)) STORED`, &DDL{Filename: "filename", List: []DDLStmt{
&AlterTable{
Name: "products",
Alteration: AddColumn{Def: ColumnDef{
Name: "item",
Type: Type{Base: String, Array: true, Len: MaxLen},
Position: line(1),
Generated: Func{
Name: "ARRAY_LAST",
Args: []Expr{ID("itemDetails")},
},
}},
Position: line(1),
},
}}},
{
`ALTER STATISTICS auto_20191128_14_47_22UTC SET OPTIONS (allow_gc=false)`,
&DDL{
Expand Down
Loading