Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(spanner): wait for background goroutines to complete #10095

Merged
merged 4 commits into from
Aug 21, 2024
Merged

fix(spanner): wait for background goroutines to complete #10095

merged 4 commits into from
Aug 21, 2024

Commits on May 31, 2024

  1. fix(spanner): wait for things to complete 

    As a good rule of thumb every single goroutine needs to be waited
to be completed, otherwise it's easy to introduce issues where the
created goroutine outlives the parent and accesses variables or
services that have been shutdown.
    @egonelbre
    egonelbre committed May 31, 2024
    Configuration menu
    Copy the full SHA
    7b7d6d5 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Merge branch 'main' into fixrace

    @egonelbre
    egonelbre committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    009d48d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fixrace

    @rahul2393
    rahul2393 committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    7a13385 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into fixrace

    @rahul2393
    rahul2393 committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    a46769a View commit details
    Browse the repository at this point in the history