Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner): Add RESOURCE_EXHAUSTED to retryable transaction codes #10412

Merged
merged 12 commits into from
Jul 18, 2024

Conversation

Vizerai
Copy link
Contributor

@Vizerai Vizerai commented Jun 21, 2024

feat: Add RESOURCE_EXHAUSTED to retryable transaction codes.

This is part of the SpanFe flow control work.

@Vizerai Vizerai requested review from a team as code owners June 21, 2024 19:35
@Vizerai Vizerai changed the title Add RESOURCE_EXHAUSTED to retryable transaction codes feat: Add RESOURCE_EXHAUSTED to retryable transaction codes Jun 21, 2024
@codyoss codyoss changed the title feat: Add RESOURCE_EXHAUSTED to retryable transaction codes feat(spanner): Add RESOURCE_EXHAUSTED to retryable transaction codes Jun 21, 2024
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Jun 22, 2024
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 1, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 1, 2024
@Vizerai
Copy link
Contributor Author

Vizerai commented Jul 17, 2024

@rahul2393 can you add googleapis/yoshi-go-admins as a reviewer? I cannot add anyone to the reviewer list.

@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 18, 2024
@rahul2393 rahul2393 enabled auto-merge (squash) July 18, 2024 02:11
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 18, 2024
@rahul2393
Copy link
Contributor

@Vizerai I can review and merge this PR, there is a build failure though

./retry_test.go:123:6: TestRetryerRespectsServerDelay redeclared in this block
	./retry_test.go:102:6: other declaration of TestRetryerRespectsServerDelay

Can you please fix that?

auto-merge was automatically disabled July 18, 2024 05:02

Head branch was pushed to by a user without write access

@rahul2393 rahul2393 enabled auto-merge (squash) July 18, 2024 05:16
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 18, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 18, 2024
@rahul2393 rahul2393 merged commit 29b52dc into googleapis:main Jul 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants