chore(storage/transfermanager): DownloadDirectory fails if file already exists #10507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
BrennaEpp
commented
Jul 3, 2024
•
- Also adds cleanup on error.
tritone
reviewed
Jul 4, 2024
| return fmt.Errorf("transfermanager: DownloadDirectory failed to make directory(%q): %w", objDirectory, err) | ||
| } | ||
|
|
||
| // Check if the file exists. |
There was a problem hiding this comment.
I'm wondering if we should just stat everything first in a loop before creating any files, assuming the user doesn't want SkipIfExists behavior? That way we would avoid having to do any cleanup steps. And in general I would expect that, if files already exist, it will be a mistake in terms of the provided path and so we'll encounter the issue fairly quickly.
There was a problem hiding this comment.
It helps us avoid clean up steps unless there are failures in directory or file creation. I went ahead and made that change.
tritone
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.