Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pubsub/pstest): add Message.Topic field and populate on publish #10510

Merged
merged 1 commit into from
Jul 8, 2024
Merged

feat(pubsub/pstest): add Message.Topic field and populate on publish #10510

merged 1 commit into from
Jul 8, 2024
+2 −0

Conversation

adzil
Copy link
Contributor

@adzil adzil commented Jul 5, 2024

This PR introduces new field Topic to the pubsub/pstest.Message that contains the Topic ID of published Pub/Sub messages to the pstest.Server.

Closes #10439

@adzil adzil requested review from shollyman and a team as code owners July 5, 2024 06:23
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Jul 5, 2024
@adzil adzil mentioned this pull request Jul 5, 2024
Closed
@hongalex hongalex added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 5, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 5, 2024
@hongalex hongalex merged commit 01bf051 into googleapis:main Jul 8, 2024
8 checks passed
@release-please release-please bot mentioned this pull request Jul 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongalex hongalex hongalex approved these changes

@shollyman shollyman Awaiting requested review from shollyman shollyman is a code owner

Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pubsub/pstest: add TopicID field to the Message struct
3 participants
@adzil @hongalex @kokoro-team