chore(storage): remove x-goog-api-client header merging from invoke #10514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
BrennaEpp
commented
Jul 6, 2024
- go version must still be included since uploads do not always include the version otherwise (other operations will see the value repeated, however)
- xml still has to do the merging
- grpc had a bug where the ctx from invoke was not being used so the header wouldn't always be sent
- go version must still be included since uploads do not always include the version otherwise (other operations will see the value repeated, however) - xml still has to do the merging - grpc had a bug where the ctx from invoke was not being used so the header wouldn't always be sent
tritone
reviewed
Jul 8, 2024
storage/http_client.go
Outdated
| @@ -860,9 +860,21 @@ func (c *httpStorageClient) newRangeReaderXML(ctx context.Context, params *newRa | |||
| // Set custom headers passed in via the context. This is only required for XML; | |||
| // for gRPC & JSON this is handled in the GAPIC and Apiary layers respectively. | |||
| ctxHeaders := callctx.HeadersFromContext(ctx) | |||
|
|
|||
| for k, vals := range ctxHeaders { | |||
There was a problem hiding this comment.
Can we add a test for this logic? Could either use a mock transport, or factor out the header logic into a separate func for easy testing.
tritone
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.