Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner): Executor framework server and worker proxy #8714

Merged
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
21cfc83
feat(spanner): add executor code
harshachinta Oct 13, 2023
036ee33
feat(spanner): add license headers
harshachinta Oct 13, 2023
1750cdc
feat(spanner): add proto and autogenerated code
harshachinta Oct 13, 2023
4763441
Merge branch 'main' into spanner-executor-framework-v1
harshachinta Oct 13, 2023
b44e805
feat(spanner): add cloud_executor file which has helper methods
harshachinta Oct 14, 2023
afab96c
Merge branch 'main' into spanner-executor-framework-v1
harshachinta Oct 14, 2023
cff3d6c
feat(spanner): make code modular
harshachinta Oct 19, 2023
4ee2b44
Merge branch 'main' into spanner-executor-framework-v1
harshachinta Oct 19, 2023
1a5073f
feat(spanner): move autogenerated protos to a different PR
harshachinta Oct 20, 2023
6200c91
Merge branch 'main' into spanner-executor-framework-v1
harshachinta Oct 20, 2023
89adfa3
feat(spanner): rename file
harshachinta Oct 20, 2023
3e235ed
feat(spanner): rename
harshachinta Oct 20, 2023
01a3215
feat(spanner): use string.join
harshachinta Oct 20, 2023
cf0ee5f
feat(spanner): add file responsibility
harshachinta Oct 20, 2023
ac66668
Merge branch 'main' into spanner-executor-framework-v1
harshachinta Oct 27, 2023
030cae8
feat(spanner): coder refactoring
harshachinta Oct 29, 2023
038b165
feat(spanner): coder refactoring
harshachinta Oct 29, 2023
847d624
Merge branch 'main' into spanner-executor-framework-v1
harshachinta Oct 29, 2023
f7e288b
Merge branch 'main' into spanner-executor-framework-v1
harshachinta Oct 30, 2023
8241042
Merge branch 'main' into spanner-executor-framework-v1
harshachinta Oct 30, 2023
91c2f3f
Merge branch 'main' into spanner-executor-framework-v1
harshachinta Oct 31, 2023
88dc544
Merge branch 'main' into spanner-executor-framework-v1
harshachinta Nov 1, 2023
d654ce1
feat(spanner): update go.mod
harshachinta Nov 1, 2023
e74d650
feat(spanner): lint fixes
harshachinta Nov 1, 2023
16149aa
feat(spanner): lint fixes
harshachinta Nov 1, 2023
5c83271
Merge branch 'main' into spanner-executor-framework-v1
harshachinta Nov 2, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat(spanner): coder refactoring
  • Loading branch information
harshachinta committed Oct 29, 2023
commit 030cae88459bddfbdb411d12200ce74023e7b9fe
30 changes: 0 additions & 30 deletions spanner/cloudexecutor/executor/cloud_client_executor_mapping.go

This file was deleted.

332 changes: 0 additions & 332 deletions spanner/cloudexecutor/executor/cloud_executor_util.go

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,14 @@

package executor

// cloud_executor_impl.go contains the implementation of the executor proxy RPC.
// executor_proxy_server_impl.go contains the implementation of the executor proxy RPC.
// This RPC gets invoked through the gRPC stream exposed via proxy port by worker_proxy.go file.

import (
"context"

executorpb "cloud.google.com/go/spanner/cloudexecutor/proto"
"cloud.google.com/go/spanner/test/cloudexecutor/executor/internal/input_stream"
executorpb "cloud.google.com/go/spanner/test/cloudexecutor/proto"
"google.golang.org/api/option"
)

Expand All @@ -37,10 +38,11 @@ func NewCloudProxyServer(ctx context.Context, opts []option.ClientOption) (*Clou

// ExecuteActionAsync is implementation of ExecuteActionAsync in SpannerExecutorProxyServer. It's a
// streaming method in which client and server exchange SpannerActions and SpannerActionOutcomes.
func (s *CloudProxyServer) ExecuteActionAsync(stream executorpb.SpannerExecutorProxy_ExecuteActionAsyncServer) error {
handler := &cloudStreamHandler{
cloudProxyServer: s,
stream: stream,
func (s *CloudProxyServer) ExecuteActionAsync(inputStream executorpb.SpannerExecutorProxy_ExecuteActionAsyncServer) error {
handler := &input_stream.CloudStreamHandler{
Stream: inputStream,
ServerContext: s.serverContext,
Options: s.options,
}
return handler.execute()
return handler.Execute()
}
Loading
Loading