Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(spanner): use json.Number for decoding unknown values from spanner #9104

Closed
wants to merge 1 commit into from
Closed

fix(spanner): use json.Number for decoding unknown values from spanner #9104

wants to merge 1 commit into from

Conversation

rahul2393
Copy link
Contributor

@rahul2393 rahul2393 commented Dec 8, 2023 •
edited
Loading

  1. First commit added to show reading integer values back from Spanner in NullJson type results into loss of precision.
Screenshot 2023-12-08 at 15 24 11

@rahul2393 rahul2393 requested review from a team as code owners December 8, 2023 09:42
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the Spanner API. labels Dec 8, 2023
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 8, 2023
@rahul2393
Copy link
Contributor Author

Continued here #9054

@rahul2393 rahul2393 closed this Dec 12, 2023
@codyoss codyoss deleted the fix-json-type-issues branch April 23, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. kokoro:force-run Add this label to force Kokoro to re-run the tests. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rahul2393