Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datastore): Add query profiling #9200

Merged
merged 23 commits into from
May 7, 2024
Merged
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
730d947
feat(datastore): Query profiling
bhshkh Dec 18, 2023
5825267
feat(datastore): remove comment
bhshkh Dec 18, 2023
bf802dc
Merge branch 'main' into feature/ds-query-profiling
bhshkh Dec 27, 2023
4d8a1f1
feat(datastore): Refactor test
bhshkh Dec 27, 2023
1f507c6
Merge branch 'main' into feature/ds-query-profiling
bhshkh Jan 10, 2024
4276f61
feat(datastore): Refactor integration test
bhshkh Jan 17, 2024
8420179
Merge branch 'main' into feature/ds-query-profiling
bhshkh Feb 13, 2024
21923dc
feat(datastore): Use ExplainOptions instead of QueryMode
bhshkh Feb 14, 2024
365c625
feat(datastore): Refactoring code
bhshkh Feb 14, 2024
5033f50
feat(datastore): Additional comments
bhshkh Feb 14, 2024
ac60830
feat(datastore): Resolving vet failures
bhshkh Feb 14, 2024
252f0e9
Merge branch 'googleapis:main' into feature/ds-query-profiling
bhshkh Mar 18, 2024
f0ba17f
feat(datastore): Updating to match latest protos
bhshkh Mar 18, 2024
edb28f2
Merge branch 'main' into feature/ds-query-profiling
bhshkh Apr 8, 2024
54e092d
feat(datastore): Add RunWithOptions
bhshkh Apr 9, 2024
1cfdc14
Merge branch 'main' into feature/ds-query-profiling
bhshkh Apr 17, 2024
6f9f76a
fix(datastore): Resolving vet failures
bhshkh Apr 18, 2024
cf4823b
Merge branch 'main' into feature/ds-query-profiling
bhshkh Apr 18, 2024
0ceff9f
Merge branch 'main' into feature/ds-query-profiling
bhshkh Apr 18, 2024
6d23653
doc(datastore): Adde comment for preview feature
bhshkh Apr 18, 2024
700e3a1
feat(datastore): Correcting the error message
bhshkh Apr 22, 2024
144e73e
Merge branch 'main' into feature/ds-query-profiling
bhshkh May 7, 2024
4730d3e
feat(datastore): Resolving test failures
bhshkh May 7, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat(datastore): Additional comments
  • Loading branch information
bhshkh committed Feb 14, 2024
commit 5033f507a24fa11241128c980347aa5ea6884d36
2 changes: 2 additions & 0 deletions datastore/query.go
Original file line number Diff line number Diff line change
Expand Up @@ -634,6 +634,8 @@

// ExplainOptions is explain options for the query.
type ExplainOptions struct {
// When false (the default), the query will be planned, returning only
// metrics from the planning stages.
// When true, the query will be planned and executed, returning the full
// query results along with both planning and execution stage metrics.
Analyze bool
Expand Down Expand Up @@ -669,7 +671,7 @@
return s, nil
}

// Planning phase information for the query.

Check failure on line 674 in datastore/query.go

View workflow job for this annotation

GitHub Actions / vet

comment on exported type Plan should be of the form "Plan ..." (with optional leading article)
type Plan struct {
// The indexes selected for the query. For example:
//
Expand All @@ -680,7 +682,7 @@
IndexesUsed []*map[string]interface{}
}

// Execution statistics for the query.

Check failure on line 685 in datastore/query.go

View workflow job for this annotation

GitHub Actions / vet

comment on exported type ExecutionStats should be of the form "ExecutionStats ..." (with optional leading article)
type ExecutionStats struct {
// Total number of results returned, including documents, projections,
// aggregation results, keys.
Expand Down
Loading