Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: external table definition parquet format options #2535

Merged
merged 6 commits into from
Mar 7, 2023
Merged

fix: external table definition parquet format options #2535

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e737ff6
fix: set parquet format options for external tables
jbeluch Feb 19, 2023
51e24c9
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Feb 23, 2023
732b131
fix: set parquet format options for external tables
jbeluch Mar 6, 2023
628e5b3
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Mar 6, 2023
aa836f6
fix: set parquet format options for external tables
jbeluch Mar 6, 2023
b86f807
Merge branch 'main' into main
Neenu1995 Mar 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: set parquet format options for external tables
  • Loading branch information
@jbeluch
jbeluch committed Mar 6, 2023
commit 732b131afd50a3a37249013cae9710b2ce14af6d
4 changes: 2 additions & 2 deletions google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/FormatOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,8 @@ public static FormatOptions googleSheets() {
}

/** Default options for PARQUET format. */
public static FormatOptions parquet() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the return type as is.
Changing it will break existing customers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed.

should i handle squashing commits myself or is it done at merge time?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jbeluch. The commits should be updated now.

return new FormatOptions(PARQUET);
public static ParquetOptions parquet() {
return ParquetOptions.newBuilder().build();
}

/** Default options for the ORC format. */
Expand Down