Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: null field mode inconsistency #2863

Merged
merged 3 commits into from
Jul 12, 2024
Merged

fix: null field mode inconsistency #2863

merged 3 commits into from
Jul 12, 2024

Conversation

obada-ab
Copy link
Member

@obada-ab obada-ab commented Sep 5, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2730 ☕️

@obada-ab obada-ab requested a review from a team as a code owner September 5, 2023 11:44
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/java-bigquery API. labels Sep 5, 2023
@obada-ab obada-ab added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 25, 2023
@PhongChuong
Merge branch 'main' into null-field-mode
1626d93 
# Conflicts:
#	google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java
@PhongChuong PhongChuong removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 12, 2024
@PhongChuong PhongChuong merged commit b9e96e3 into main Jul 12, 2024
21 checks passed
@PhongChuong PhongChuong deleted the null-field-mode branch July 12, 2024 16:36
@release-please release-please bot mentioned this pull request Jul 12, 2024
Merged
This was referenced Jul 30, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhongChuong PhongChuong PhongChuong approved these changes

@chalmerlowe chalmerlowe Awaiting requested review from chalmerlowe chalmerlowe is a code owner automatically assigned from googleapis/api-bigquery

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The Field mode normalization for null values is incorrect and sets it as an empty String.
2 participants
@obada-ab @PhongChuong