Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: @Nullable annotations on builder methods #3222

Merged
merged 5 commits into from
Apr 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,20 +53,20 @@ If you are using Maven without the BOM, add this to your dependencies:
If you are using Gradle 5.x or later, add this to your dependencies:

```Groovy
implementation platform('com.google.cloud:libraries-bom:26.34.0')
implementation platform('com.google.cloud:libraries-bom:26.37.0')

implementation 'com.google.cloud:google-cloud-bigquery'
```
If you are using Gradle without BOM, add this to your dependencies:

```Groovy
implementation 'com.google.cloud:google-cloud-bigquery:2.38.2'
implementation 'com.google.cloud:google-cloud-bigquery:2.39.0'
```

If you are using SBT, add this to your dependencies:

```Scala
libraryDependencies += "com.google.cloud" % "google-cloud-bigquery" % "2.38.2"
libraryDependencies += "com.google.cloud" % "google-cloud-bigquery" % "2.39.0"
```
<!-- {x-version-update-end} -->

Expand Down Expand Up @@ -351,7 +351,7 @@ Java is a registered trademark of Oracle and/or its affiliates.
[kokoro-badge-link-5]: http://storage.googleapis.com/cloud-devrel-public/java/badges/java-bigquery/java11.html
[stability-image]: https://img.shields.io/badge/stability-stable-green
[maven-version-image]: https://img.shields.io/maven-central/v/com.google.cloud/google-cloud-bigquery.svg
[maven-version-link]: https://central.sonatype.com/artifact/com.google.cloud/google-cloud-bigquery/2.38.2
[maven-version-link]: https://central.sonatype.com/artifact/com.google.cloud/google-cloud-bigquery/2.39.0
[authentication]: https://github.com/googleapis/google-cloud-java#authentication
[auth-scopes]: https://developers.google.com/identity/protocols/oauth2/scopes
[predefined-iam-roles]: https://cloud.google.com/iam/docs/understanding-roles#predefined_roles
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,6 @@ Builder withDefaultValues() {
*
* @param useReadAPI or {@code true} for none
*/
@Nullable
public abstract Builder setUseReadAPI(Boolean useReadAPI);

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,34 +31,34 @@ public abstract static class Builder {
* Sets the total row count to page row count ratio used to determine whether to us the
* BigQueryStorage Read client to fetch result sets after the first page.
*/
@Nullable
public abstract Builder setTotalToPageRowCountRatio(Long ratio);
PhongChuong marked this conversation as resolved.
Show resolved Hide resolved

/**
* Sets the minimum number of table rows in the query results used to determine whether to us
* the BigQueryStorage Read client to fetch result sets after the first page.
*/
@Nullable
public abstract Builder setMinResultSize(Long numRows);
PhongChuong marked this conversation as resolved.
Show resolved Hide resolved

/**
* Sets the maximum number of table rows allowed in buffer before streaming them to the
* BigQueryResult.
*/
@Nullable
public abstract Builder setBufferSize(Long bufferSize);
PhongChuong marked this conversation as resolved.
Show resolved Hide resolved

/** Creates a {@code ReadClientConnectionConfiguration} object. */
public abstract ReadClientConnectionConfiguration build();
}

/** Returns the totalToPageRowCountRatio in this configuration. */
@Nullable
public abstract Long getTotalToPageRowCountRatio();

/** Returns the minResultSize in this configuration. */
@Nullable
public abstract Long getMinResultSize();

/** Returns the bufferSize in this configuration. */
@Nullable
public abstract Long getBufferSize();

public abstract Builder toBuilder();
Expand Down
Loading