docs: Documentation update for OpenTelemetry and tracing #1657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtabasko
suggested changes
Jul 12, 2024
|
Thank you for the great feedback @mtabasko! Updated the PR with fixes to your comments. |
gkevinzheng
reviewed
Jul 12, 2024
.readme-partials.yaml
Outdated
| @@ -227,4 +227,17 @@ custom_content: | | |||
| <artifactId>google-cloud-logging-servlet-initializer</artifactId> | |||
| </dependency> | |||
| ``` | |||
| #### Population of Log Entrys' Trace/Span ID | |||
There was a problem hiding this comment.
Do we want to title this "Automatic Trace/Span ID Extraction" to be consistent with the language used in other client libraries?
There was a problem hiding this comment.
Hi Kevin, Java-logging is a bit special here. We don't have auto extraction for Http headers unless it's through manual setting or using servlet-initializer.
aabmass
approved these changes
Jul 12, 2024
mtabasko
suggested changes
Jul 12, 2024
mtabasko
approved these changes
Jul 13, 2024
gkevinzheng
approved these changes
Jul 15, 2024
|
/gcbrun |
1 similar comment
|
/gcbrun |
The OwlBot was supposed to update the README. However there is a hermetic build change which is deprecating Owlbot for java handwritten client libraries(go/hermetic-build-integration-hw-libraries). @diegomarquezp suggested we update this manually for now while his team is working on a fix. For now we have manually updated README. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Here is a preview for the updated ReadMe: