Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove native image sample in favor of sample hosted in google-cloud-java #2105

Merged
merged 7 commits into from
Jul 15, 2024

Conversation

mpeddada1
Copy link
Contributor

This PR removes the library-specific Pub/Sub native image sample in favor of a single sample maintained in https://github.com/googleapis/google-cloud-java/tree/main/java-samples/native-image-sample

Documented externally in https://cloud.google.com/java/docs/compile-native-images#whats_next

@mpeddada1 mpeddada1 requested review from a team as code owners July 3, 2024 19:02
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: pubsub Issues related to the googleapis/java-pubsub API. samples Issues that are directly related to samples. labels Jul 3, 2024
@michaelpri10 michaelpri10 marked this pull request as draft July 10, 2024 14:18
@michaelpri10 michaelpri10 marked this pull request as ready for review July 10, 2024 14:18
@mpeddada1 mpeddada1 merged commit 8b07974 into main Jul 15, 2024
24 checks passed
@mpeddada1 mpeddada1 deleted the remove-native-image-sample branch July 15, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/java-pubsub API. samples Issues that are directly related to samples. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants