Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: track batch size using serialized size of PublishRequest #2113

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: track batch size using serialized size of PublishRequest #2113

wants to merge 4 commits into from

Conversation

sjvanrossum
Copy link

@sjvanrossum sjvanrossum commented Jul 12, 2024 •
edited
Loading

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2106 ☕️

@sjvanrossum sjvanrossum requested a review from a team as a code owner July 12, 2024 14:31
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: pubsub Issues related to the googleapis/java-pubsub API. labels Jul 12, 2024
@sjvanrossum sjvanrossum mentioned this pull request Jul 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaelpri10 michaelpri10

Labels
api: pubsub Issues related to the googleapis/java-pubsub API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request batching does not track encoding overhead accurately
2 participants
@sjvanrossum @michaelpri10