Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add a sample for max commit delays #2941

Merged
merged 7 commits into from
Apr 20, 2024
Merged

docs: add a sample for max commit delays #2941

merged 7 commits into from
Apr 20, 2024

Conversation

nginsberg-google
Copy link
Contributor

add a sample for max commit delays

@nginsberg-google nginsberg-google requested a review from a team as a code owner March 7, 2024 04:12
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Mar 7, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. labels Mar 7, 2024
@rahul2393 rahul2393 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 12, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 12, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 12, 2024
@nginsberg-google nginsberg-google requested a review from a team as a code owner March 12, 2024 04:24
@arpan14
Copy link
Collaborator

arpan14 commented Mar 18, 2024

Please hold on merging this PR. We need to correct the return type at - #2953

@olavloite olavloite changed the title feat(spanner): add a sample for max commit delays docs: add a sample for max commit delays Apr 20, 2024
@olavloite olavloite added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 20, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 20, 2024
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 20, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 20, 2024
@olavloite olavloite merged commit d3b5097 into googleapis:main Apr 20, 2024
29 of 31 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 20, 2024
@release-please release-please bot mentioned this pull request Apr 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olavloite olavloite olavloite left review comments

@arpan14 arpan14 arpan14 approved these changes

@rahul2393 rahul2393 rahul2393 approved these changes

Assignees

@Sita04 Sita04

Labels
api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nginsberg-google @arpan14 @olavloite @rahul2393 @Sita04 @yoshi-kokoro