-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Managed Autoscaler #1965
feat: Managed Autoscaler #1965
Conversation
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
bb98bac
to
179f89b
Compare
feat: code changes for managed autoscaler code changes for managed autoscaler add license lint changes remove comments remove .vscode folder modify timeout in monarch fix mismatched region tag change copyright year to 2023
f459fe2
to
119ae60
Compare
@@ -0,0 +1,93 @@ | |||
/** | |||
* Copyright 2023 Google LLC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Copyright 2023 Google LLC | |
* Copyright 2024 Google LLC |
@@ -481,17 +482,21 @@ class Spanner extends GrpcService { | |||
displayName, | |||
nodeCount: config.nodes, | |||
processingUnits: config.processingUnits, | |||
autoscalingConfig: config.autoscalingConfig, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to do changes for Update Instance to handle below use case
When autoscaling config is set then node and processing unit should not be passed
Closing this PR, as there is no more need of this sample. I will add the similar samples using admin client. |
This PR contains code changes for manages autoscaler.