Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for blind writes #2065

Merged
merged 29 commits into from
Jul 29, 2024
Merged

feat: add support for blind writes #2065

merged 29 commits into from
Jul 29, 2024

Conversation

alkatrivedi
Copy link
Contributor

@alkatrivedi alkatrivedi commented Jun 20, 2024 •
edited
Loading

This PR contains the support for Blind Writes API in Spanner.

@alkatrivedi alkatrivedi requested review from a team as code owners June 20, 2024 11:13
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/nodejs-spanner API. labels Jun 20, 2024
@alkatrivedi alkatrivedi added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 4, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 4, 2024
@product-auto-label product-auto-label bot added size: l Pull request size is large. size: m Pull request size is medium. and removed size: m Pull request size is medium. size: l Pull request size is large. labels Jul 9, 2024
@alkatrivedi alkatrivedi added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 9, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 9, 2024
surbhigarg92
surbhigarg92 reviewed Jul 17, 2024
View reviewed changes
src/database.ts Outdated Show resolved Hide resolved
src/database.ts Outdated Show resolved Hide resolved
src/database.ts Outdated Show resolved Hide resolved
src/database.ts Outdated Show resolved Hide resolved
test/database.ts Show resolved Hide resolved
test/database.ts Outdated Show resolved Hide resolved
@alkatrivedi alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 24, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 24, 2024
@alkatrivedi alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 25, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 25, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 25, 2024
@alkatrivedi alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 25, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 25, 2024
olavloite
olavloite approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a couple of minor nits.

src/database.ts Show resolved Hide resolved
src/database.ts Show resolved Hide resolved
src/database.ts Outdated Show resolved Hide resolved
src/transaction.ts Outdated Show resolved Hide resolved
src/transaction.ts Outdated Show resolved Hide resolved
test/spanner.ts Outdated Show resolved Hide resolved
test/spanner.ts Outdated Show resolved Hide resolved
test/spanner.ts Outdated Show resolved Hide resolved
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 26, 2024
@alkatrivedi alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 29, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 29, 2024
@surbhigarg92 surbhigarg92 added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 29, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 29, 2024
@alkatrivedi alkatrivedi merged commit 62fc0a4 into googleapis:main Jul 29, 2024
16 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 29, 2024
@release-please release-please bot mentioned this pull request Jul 26, 2024
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 29, 2024
@release-please
chore(main): release 7.11.0 (#2084)
f34f464 
🤖 I have created a release *beep* *boop*
---


## [7.11.0](https://togithub.com/googleapis/nodejs-spanner/compare/v7.10.0...v7.11.0) (2024-07-29)


### Features

* Add support for blind writes ([#2065](https://togithub.com/googleapis/nodejs-spanner/issues/2065)) ([62fc0a4](https://togithub.com/googleapis/nodejs-spanner/commit/62fc0a47327017c115466b9e89e53dbd778579af))
* **spanner:** Add samples for instance partitions ([#2083](https://togithub.com/googleapis/nodejs-spanner/issues/2083)) ([b91e284](https://togithub.com/googleapis/nodejs-spanner/commit/b91e2849056df9894e0590cb71e21c13319e6d70))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olavloite olavloite olavloite approved these changes

@surbhigarg92 surbhigarg92 surbhigarg92 approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. kokoro:force-run Add this label to force Kokoro to re-run the tests. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alkatrivedi @olavloite @surbhigarg92 @yoshi-kokoro