Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error serialization in resumable-upload.ts #2493

Merged
merged 4 commits into from
Jul 8, 2024

Conversation

eagleeye
Copy link
Contributor

@eagleeye eagleeye commented Jul 5, 2024

Existing error handling has wrong error serialization with .toString(), that leads to [object Object] error messages. Example:
Error: Retry limit exceeded - [object Object]
at Upload.attemptDelayedRetry (/usr/src/app/node_modules/@google-cloud/storage/build/cjs/src/resumable-upload.js:818:26)

Better solution would be JSON.stringify the error

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

the issue was discussed with Google Support via DoIT support team as a intermediate

@eagleeye eagleeye requested review from a team as code owners July 5, 2024 06:06
Copy link

conventional-commit-lint-gcf bot commented Jul 5, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/nodejs-storage API. labels Jul 5, 2024
eagleeye and others added 2 commits July 8, 2024 13:16
Existing error handling has wrong error serialization with .toString(), that leads to [object Object] error messages.
Example:
 Error: Retry limit exceeded - [object Object]
 at Upload.attemptDelayedRetry (/usr/src/app/node_modules/@google-cloud/storage/build/cjs/src/resumable-upload.js:818:26)

Better solution would be JSON.stringify the error
@ddelgrosso1 ddelgrosso1 changed the title Fix error serialization in resumable-upload.ts fix: error serialization in resumable-upload.ts Jul 8, 2024
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jul 8, 2024
@ddelgrosso1
Copy link
Contributor

Thank you for the contribution @eagleeye

@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 8, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 8, 2024
@ddelgrosso1 ddelgrosso1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 8, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 8, 2024
@ddelgrosso1 ddelgrosso1 merged commit c2e555c into googleapis:main Jul 8, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/nodejs-storage API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants