Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: edit presubmit for to simplify configuration #1915

Merged
merged 18 commits into from
May 15, 2024
Merged

fix: edit presubmit for to simplify configuration #1915

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
8c943af
add new presubmit for test purposes
chalmerlowe May 9, 2024
92116c0
add additional sessions
chalmerlowe May 10, 2024
0d3444a
Update .kokoro/presubmit/presubmit-2.cfg
chalmerlowe May 10, 2024
0282e1b
Update .kokoro/presubmit/presubmit-2.cfg
chalmerlowe May 10, 2024
6588e0d
added timer to nox sessions
chalmerlowe May 10, 2024
bb690fd
Update .kokoro/presubmit/presubmit-2.cfg
chalmerlowe May 10, 2024
936ba65
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] May 10, 2024
ea0be04
Merge branch 'test-kokoro-refactor' of https://github.com/googleapis/…
gcf-owl-bot[bot] May 10, 2024
839ee1b
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] May 10, 2024
ce55faa
Merge branch 'test-kokoro-refactor' of https://github.com/googleapis/…
gcf-owl-bot[bot] May 10, 2024
6177f09
removes references to most environment variables
chalmerlowe May 13, 2024
05014ce
testing the use of base names for the nox sessions
chalmerlowe May 13, 2024
b84504a
removes references to unneeded linting and typing env variables
chalmerlowe May 13, 2024
0dd852a
change file name and update env_vars in presubmit-2
chalmerlowe May 13, 2024
e7a10f4
remove timed decorators
chalmerlowe May 13, 2024
204aa2c
revert several files
chalmerlowe May 13, 2024
45af713
Update noxfile.py
chalmerlowe May 14, 2024
a91de8c
remove test, remove unneeded vars, etc
chalmerlowe May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removes references to most environment variables
  • Loading branch information
@chalmerlowe
chalmerlowe committed May 13, 2024
commit 6177f097c49d198ab48089d504bc29874d811748
25 changes: 0 additions & 25 deletions exp-time.py
View file
Open in desktop

This file was deleted.

32 changes: 16 additions & 16 deletions noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,8 +162,8 @@ def mypy(session):
"""Run type checks with mypy."""

# Check the value of `RUN_LINTING_TYPING_TESTS` env var. It defaults to true.
if os.environ.get("RUN_LINTING_TYPING_TESTS", "true") == "false":
session.skip("RUN_LINTING_TYPING_TESTS is set to false, skipping")
# if os.environ.get("RUN_LINTING_TYPING_TESTS", "true") == "false":
# session.skip("RUN_LINTING_TYPING_TESTS is set to false, skipping")

session.install("-e", ".[all]")
session.install(MYPY_VERSION)
Expand All @@ -188,8 +188,8 @@ def pytype(session):
# https://github.com/googleapis/python-bigquery/issues/655

# Check the value of `RUN_LINTING_TYPING_TESTS` env var. It defaults to true.
if os.environ.get("RUN_LINTING_TYPING_TESTS", "true") == "false":
session.skip("RUN_LINTING_TYPING_TESTS is set to false, skipping")
# if os.environ.get("RUN_LINTING_TYPING_TESTS", "true") == "false":
# session.skip("RUN_LINTING_TYPING_TESTS is set to false, skipping")

session.install("attrs==20.3.0")
session.install("-e", ".[all]")
Expand All @@ -208,8 +208,8 @@ def system(session):
)

# Check the value of `RUN_SYSTEM_TESTS` env var. It defaults to true.
if os.environ.get("RUN_SYSTEM_TESTS", "true") == "false":
session.skip("RUN_SYSTEM_TESTS is set to false, skipping")
# if os.environ.get("RUN_SYSTEM_TESTS", "true") == "false":
# session.skip("RUN_SYSTEM_TESTS is set to false, skipping")

# Sanity check: Only run system tests if the environment variable is set.
if not os.environ.get("GOOGLE_APPLICATION_CREDENTIALS", ""):
Expand Down Expand Up @@ -257,8 +257,8 @@ def mypy_samples(session):
"""Run type checks with mypy."""

# Check the value of `RUN_LINTING_TYPING_TESTS` env var. It defaults to true.
if os.environ.get("RUN_LINTING_TYPING_TESTS", "true") == "false":
session.skip("RUN_LINTING_TYPING_TESTS is set to false, skipping")
# if os.environ.get("RUN_LINTING_TYPING_TESTS", "true") == "false":
# session.skip("RUN_LINTING_TYPING_TESTS is set to false, skipping")

session.install("pytest")
for requirements_path in CURRENT_DIRECTORY.glob("samples/*/requirements.txt"):
Expand Down Expand Up @@ -297,8 +297,8 @@ def snippets(session):
"""Run the snippets test suite."""

# Check the value of `RUN_SNIPPETS_TESTS` env var. It defaults to true.
if os.environ.get("RUN_SNIPPETS_TESTS", "true") == "false":
session.skip("RUN_SNIPPETS_TESTS is set to false, skipping")
# if os.environ.get("RUN_SNIPPETS_TESTS", "true") == "false":
# session.skip("RUN_SNIPPETS_TESTS is set to false, skipping")

constraints_path = str(
CURRENT_DIRECTORY / "testing" / f"constraints-{session.python}.txt"
Expand Down Expand Up @@ -446,8 +446,8 @@ def lint(session):
"""

# Check the value of `RUN_LINTING_TYPING_TESTS` env var. It defaults to true.
if os.environ.get("RUN_LINTING_TYPING_TESTS", "true") == "false":
session.skip("RUN_LINTING_TYPING_TESTS is set to false, skipping")
# if os.environ.get("RUN_LINTING_TYPING_TESTS", "true") == "false":
# session.skip("RUN_LINTING_TYPING_TESTS is set to false, skipping")

session.install("flake8", BLACK_VERSION)
session.install("-e", ".")
Expand All @@ -465,8 +465,8 @@ def lint_setup_py(session):
"""Verify that setup.py is valid (including RST check)."""

# Check the value of `RUN_LINTING_TYPING_TESTS` env var. It defaults to true.
if os.environ.get("RUN_LINTING_TYPING_TESTS", "true") == "false":
session.skip("RUN_LINTING_TYPING_TESTS is set to false, skipping")
# if os.environ.get("RUN_LINTING_TYPING_TESTS", "true") == "false":
# session.skip("RUN_LINTING_TYPING_TESTS is set to false, skipping")

session.install("docutils", "Pygments")
session.run("python", "setup.py", "check", "--restructuredtext", "--strict")
Expand All @@ -480,8 +480,8 @@ def blacken(session):
"""

# Check the value of `RUN_LINTING_TYPING_TESTS` env var. It defaults to true.
if os.environ.get("RUN_LINTING_TYPING_TESTS", "true") == "false":
session.skip("RUN_LINTING_TYPING_TESTS is set to false, skipping")
# if os.environ.get("RUN_LINTING_TYPING_TESTS", "true") == "false":
# session.skip("RUN_LINTING_TYPING_TESTS is set to false, skipping")

session.install(BLACK_VERSION)
session.run("black", *BLACK_PATHS)
Expand Down