Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve async sharding #977

Merged
merged 6 commits into from
Jun 11, 2024
Merged

feat: improve async sharding #977

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
376b384
use semaphore to control shard concurrency
daniel-sanche Jun 4, 2024
0dbecea
fixed lint
daniel-sanche Jun 5, 2024
48f8bc2
fixed test
daniel-sanche Jun 5, 2024
f6b187d
added test
daniel-sanche Jun 7, 2024
73f5852
added test for timeout before running shard
daniel-sanche Jun 10, 2024
e65e49f
removed import
daniel-sanche Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed lint
  • Loading branch information
@daniel-sanche
daniel-sanche committed Jun 5, 2024
commit 0dbecea45a70b5ff6c95913fb36a864023c27e50
1 change: 1 addition & 0 deletions google/cloud/bigtable/data/_async/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -750,6 +750,7 @@ async def read_rows_sharded(

# limit the number of concurrent requests using a semaphore
concurrency_sem = asyncio.Semaphore(_CONCURRENCY_LIMIT)

async def read_rows_with_semaphore(query):
async with concurrency_sem:
# calculate new timeout based on time left in overall operation
Expand Down