Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(spanner): Issue#1143 - Update dependency #1158

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

bhatt4982
Copy link
Contributor

chore(spanner): Issue#1143 - Update dependency

  • Move grpc-interceptor to extras_required named testing

Fixes #1143 🦕

@bhatt4982 bhatt4982 requested review from a team as code owners July 8, 2024 04:10
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/python-spanner API. labels Jul 8, 2024
@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 9, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 9, 2024
@harshachinta
Copy link
Contributor

harshachinta commented Jul 9, 2024

@bhatt4982 The presubmits are failing since the tetsing dependency is not getting installed when installing depenedencies.
You will need to add this testing dependency as extra similar to tracing ones here. ex: pip install mypackage[tracing, testing]

  1. SYSTEM_TEST_EXTRAS: List[str] = [
  2. Please look at references to tracing and add testing at appropriate places
    session.install("-e", ".[tracing]", "-c", constraints_path)

This reference might help you understand
https://packaging.python.org/en/latest/tutorials/installing-packages/#installing-extras

- add dependency 'testing' for pretest
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jul 9, 2024
@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 10, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 10, 2024
- add dependency 'testing' for docs and docfx sessions
@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 10, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 10, 2024
@harshachinta
Copy link
Contributor

@bhatt4982

  1. We will need to update owlbot.py https://github.com/googleapis/python-spanner/blob/112e74e6f15dc883dc347e82c890251c53a51a02/owlbot.py#L131C26-L131C33 to add testing dependency similar to tracing. Otherwise the automated PR might remove these changes,
  2. Can you fix the lint? Command: nox -s blacken

@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 11, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 11, 2024
@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 22, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 22, 2024
@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 29, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 29, 2024
@harshachinta
Copy link
Contributor

@parthea Can you help with a quick review of this PR?

@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 31, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 31, 2024
@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 6, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grpc-interceptor is listed as a dependency but is only used for testing utilities
4 participants