Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(spanner): Issue#1163 Remove dependency of dbapi from spanner_v1 #1164

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

bhatt4982
Copy link
Contributor

chore(spanner): Issue#1163 Remove dependency of spanner dbapi from spanner_v1

  • Moved BatchTransactionId dataclass from spanner_dbapi to spanner_v1.transactions

Fixes #1163 🦕

…anner_v1

 - Moved BatchTransactionId dataclass from spanner_dbapi to spanner_v1.transactions
@bhatt4982 bhatt4982 requested review from a team as code owners July 11, 2024 09:58
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/python-spanner API. labels Jul 11, 2024
@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 11, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 11, 2024
@harshachinta
Copy link
Contributor

@ankiaga Can you help review this PR?

@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 18, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 18, 2024
@harshachinta harshachinta merged commit fe20d41 into googleapis:main Jul 22, 2024
11 of 13 checks passed
@bhatt4982 bhatt4982 deleted the decouple_dbapi_and_spanner_v1 branch August 6, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependency of spanner_sbapi from spanner_v1
5 participants