-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix link to ECMA-262 specification #3691
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This PR is incorrect. It arbitrarily links to the ancient v5.1 of the spec. The current link is fine. It just redirects to https://ecma-international.org/publications-and-standards/standards/ecma-262/ Three options:
Any of the above seem okay, but not accepting this PR as is. |
@@ -5,7 +5,7 @@ This book is a *tutorial*. It aims to help you gradually learn the language. But | |||
|
|||
## Specification | |||
|
|||
[The ECMA-262 specification](https://www.ecma-international.org/publications/standards/Ecma-262.htm) contains the most in-depth, detailed and formalized information about JavaScript. It defines the language. | |||
[The ECMA-262 specification](https://262.ecma-international.org/5.1/) contains the most in-depth, detailed and formalized information about JavaScript. It defines the language. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should link to the latest standard, not v5.1 from 2011.
Please make the requested changes. After it, add a comment "/done". |
/done Thanks for the feedback. I think your option 3 would be best and changed it accordingly. |
old link was broken