Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move (qpack/hpack) HuffmanDecoder / HuffmanEncoder / NBitInteger* to common location #9554

Closed
joakime opened this issue Mar 30, 2023 · 2 comments · Fixed by #9628
Closed

Move (qpack/hpack) HuffmanDecoder / HuffmanEncoder / NBitInteger* to common location #9554

joakime opened this issue Mar 30, 2023 · 2 comments · Fixed by #9628
Assignees
@lachlan-roberts
Labels
Bug For general bugs on Jetty side

Comments

@joakime
Copy link
Contributor

joakime commented Mar 30, 2023

Jetty version(s)
Jetty 10 / 11 / 12

Java version/vendor (use: java -version)
All

OS type/version
All

Description
The code between http2 (hpack) and http3 (qpack) are very similar.
Consider moving them to a common location (jetty-util?) to have 1 place to manage issues/bugs around them.
@joakime joakime added the Bug For general bugs on Jetty side label Mar 30, 2023
@gregw
Copy link
Contributor

gregw commented Mar 31, 2023

Jetty-http would probably be a better destination than util

@joakime joakime changed the title Move (qpack/hpack) HuffmanDecoder / HuffmanEncoder / NBitInteger* to jetty-util Move (qpack/hpack) HuffmanDecoder / HuffmanEncoder / NBitInteger* to common location Mar 31, 2023
lachlan-roberts added a commit that referenced this issue Apr 5, 2023
@lachlan-roberts
Issue #9554 - move Hpack/Qpack common classes to jetty-http
f6688b0 
Signed-off-by: Lachlan Roberts <[email protected]>
lachlan-roberts added a commit that referenced this issue Apr 5, 2023
@lachlan-roberts
Issue #9554 - un-duplicate implementation for HuffmanDecoder
7fb5b42 
Signed-off-by: Lachlan Roberts <[email protected]>
lachlan-roberts added a commit that referenced this issue Apr 5, 2023
@lachlan-roberts
Issue #9554 - un-duplicate implementation for HPACK integer decoding.
183291e 
Signed-off-by: Lachlan Roberts <[email protected]>
@lachlan-roberts lachlan-roberts mentioned this issue Apr 5, 2023
Merged
@joakime joakime linked a pull request Apr 5, 2023 that will close this issue
Issue #9554 - move common hpack/qpack code to jetty-http #9628
Merged
lachlan-roberts added a commit that referenced this issue Apr 11, 2023
@lachlan-roberts
Merge pull request #9628 from eclipse/jetty-12.0.x-9554-Hpack-Qpack
7ebd07d 
Issue #9554 - move common hpack/qpack code to jetty-http
lachlan-roberts added a commit that referenced this issue Apr 11, 2023
@lachlan-roberts
Issue #9554 - move common hpack/qpack code to jetty-http
ebec7d2 
Signed-off-by: Lachlan Roberts <[email protected]>
@lachlan-roberts lachlan-roberts mentioned this issue Apr 11, 2023
Merged
lachlan-roberts added a commit that referenced this issue Apr 12, 2023
@lachlan-roberts
Issue #9554 - fix test expectations for hpack
b6d89af 
Signed-off-by: Lachlan Roberts <[email protected]>
lachlan-roberts added a commit that referenced this issue Apr 18, 2023
@lachlan-roberts
Issue #9554 - add javadoc for illegal vchar methods and move to HttpT…
09e6e6b 
…okens

Signed-off-by: Lachlan Roberts <[email protected]>
lachlan-roberts added a commit that referenced this issue Apr 18, 2023
@lachlan-roberts
Issue #9554 - add javadoc for huffman / n-bit integer classes and rem…
a7b0b72 
…ove static decode methods

Signed-off-by: Lachlan Roberts <[email protected]>
lachlan-roberts added a commit that referenced this issue May 1, 2023
@lachlan-roberts
Issue #9554 - additional cleanups and testing
1ee79f5 
Signed-off-by: Lachlan Roberts <[email protected]>
lachlan-roberts added a commit that referenced this issue May 1, 2023
@lachlan-roberts
Issue #9554 - changes from review
d0294fc 
Signed-off-by: Lachlan Roberts <[email protected]>
lachlan-roberts added a commit that referenced this issue May 1, 2023
@lachlan-roberts
Issue #9554 - changes from review
c2d2c1e 
Signed-off-by: Lachlan Roberts <[email protected]>
lachlan-roberts added a commit that referenced this issue May 3, 2023
@lachlan-roberts
Issue #9554 - changes from review
2d935ef 
Signed-off-by: Lachlan Roberts <[email protected]>
lachlan-roberts added a commit that referenced this issue May 3, 2023
@lachlan-roberts
Issue #9554 - rename NBitIntegerParser and NBitStringParser to decoders
03d6afa 
Signed-off-by: Lachlan Roberts <[email protected]>
lachlan-roberts added a commit that referenced this issue May 4, 2023
@lachlan-roberts
Issue #9554 - move common hpack/qpack code to jetty-http
040ef10 
Signed-off-by: Lachlan Roberts <[email protected]>
lachlan-roberts added a commit that referenced this issue May 4, 2023
@lachlan-roberts
Issue #9554 - fix test expectations for hpack
738ad78 
Signed-off-by: Lachlan Roberts <[email protected]>
lachlan-roberts added a commit that referenced this issue May 4, 2023
@lachlan-roberts
Issue #9554 - add javadoc for illegal vchar methods and move to HttpT…
d940e1b 
…okens

Signed-off-by: Lachlan Roberts <[email protected]>
lachlan-roberts added a commit that referenced this issue May 4, 2023
@lachlan-roberts
Issue #9554 - add javadoc for huffman / n-bit integer classes and rem…
6f5569a 
…ove static decode methods

Signed-off-by: Lachlan Roberts <[email protected]>
lachlan-roberts added a commit that referenced this issue May 4, 2023
@lachlan-roberts
Issue #9554 - additional cleanups and testing
8998df6 
Signed-off-by: Lachlan Roberts <[email protected]>
lachlan-roberts added a commit that referenced this issue May 4, 2023
@lachlan-roberts
Issue #9554 - changes from review
7d9d3a6 
Signed-off-by: Lachlan Roberts <[email protected]>
lachlan-roberts added a commit that referenced this issue May 4, 2023
@lachlan-roberts
Issue #9554 - changes from review
d78197f 
Signed-off-by: Lachlan Roberts <[email protected]>
lachlan-roberts added a commit that referenced this issue May 8, 2023
@lachlan-roberts
Merge pull request #9634 from eclipse/jetty-10.0.x-9554-qpack-hpack
a8c9eea 
Issue #9554 - move common hpack/qpack code to jetty-http (jetty-10)
@lachlan-roberts
Copy link
Contributor

fixed with #9634

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lachlan-roberts lachlan-roberts

Labels
Bug For general bugs on Jetty side
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #9554 - move common hpack/qpack code to jetty-http jetty/jetty.project
3 participants
@gregw @joakime @lachlan-roberts