-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: non-init seg_offset for growing raw-data when doing groupby(#34748) #34750
fix: non-init seg_offset for growing raw-data when doing groupby(#34748) #34750
Conversation
@MrPresent-Han E2e jenkins job failed, comment |
723c4bf
to
32d1da6
Compare
@MrPresent-Han E2e jenkins job failed, comment |
…us-io#34748) Signed-off-by: MrPresent-Han <[email protected]>
32d1da6
to
36a089e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.4 #34750 +/- ##
==========================================
- Coverage 81.15% 76.54% -4.61%
==========================================
Files 786 1045 +259
Lines 112864 136591 +23727
==========================================
+ Hits 91593 104559 +12966
- Misses 16872 27643 +10771
+ Partials 4399 4389 -10
|
please reopen the ut case that had been disabled in pr #34586 |
this is 2.4 branch, and you didn't disable that ut..... |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, MrPresent-Han The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
related: #34713
pr: #34748