Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: non-init seg_offset for growing raw-data when doing groupby(#34748) #34750

Merged

Conversation

MrPresent-Han
Copy link
Contributor

@MrPresent-Han MrPresent-Han commented Jul 17, 2024

related: #34713
pr: #34748

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jul 17, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jul 17, 2024
Copy link
Contributor

mergify bot commented Jul 17, 2024

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jul 18, 2024

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.54%. Comparing base (a26e965) to head (36a089e).
Report is 1 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #34750      +/-   ##
==========================================
- Coverage   81.15%   76.54%   -4.61%     
==========================================
  Files         786     1045     +259     
  Lines      112864   136591   +23727     
==========================================
+ Hits        91593   104559   +12966     
- Misses      16872    27643   +10771     
+ Partials     4399     4389      -10     
Files Coverage Δ
internal/core/src/common/QueryResult.h 89.39% <100.00%> (ø)

... and 302 files with indirect coverage changes

@zhagnlu
Copy link
Collaborator

zhagnlu commented Jul 18, 2024

please reopen the ut case that had been disabled in pr #34586

@MrPresent-Han
Copy link
Contributor Author

please reopen the ut case that had been disabled in pr #34586

this is 2.4 branch, and you didn't disable that ut.....

@czs007
Copy link
Contributor

czs007 commented Jul 19, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, MrPresent-Han

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit e11aab3 into milvus-io:2.4 Jul 19, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants