-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: Add Segment Level in milvus segment info APIs #34763
enhance: Add Segment Level in milvus segment info APIs #34763
Conversation
414e68d
to
49bb72b
Compare
See also milvus-io#34746 This PR add segment level field in response of `GetPersistentSegmentInfo` and `GetQuerySegmentInfo` Signed-off-by: Congqi Xia <[email protected]>
Signed-off-by: Congqi Xia <[email protected]>
Signed-off-by: Congqi Xia <[email protected]>
Signed-off-by: Congqi Xia <[email protected]>
13e3585
to
7a1aaea
Compare
Signed-off-by: Congqi Xia <[email protected]>
Signed-off-by: Congqi Xia <[email protected]>
Signed-off-by: Congqi Xia <[email protected]>
Signed-off-by: Congqi Xia <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #34763 +/- ##
==========================================
- Coverage 80.95% 80.05% -0.91%
==========================================
Files 1185 1190 +5
Lines 142758 143240 +482
==========================================
- Hits 115569 114669 -900
- Misses 22782 24155 +1373
- Partials 4407 4416 +9
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
See also milvus-io#34746 This PR add segment level field in response of `GetPersistentSegmentInfo` and `GetQuerySegmentInfo` --------- Signed-off-by: Congqi Xia <[email protected]>
Related to milvus-io#34763 Signed-off-by: Congqi Xia <[email protected]>
Related to milvus-io#34763 Signed-off-by: Congqi Xia <[email protected]>
Related to #34763 Signed-off-by: Congqi Xia <[email protected]>
…#35023) Cherry-pick from master pr: #34763 See also #34746 This PR add segment level field in response of `GetPersistentSegmentInfo` and `GetQuerySegmentInfo` --------- --------- Signed-off-by: Congqi Xia <[email protected]>
See also milvus-io#34746 This PR add segment level field in response of `GetPersistentSegmentInfo` and `GetQuerySegmentInfo` --------- Signed-off-by: Congqi Xia <[email protected]> Signed-off-by: Sumit Dubey <[email protected]>
…s-io#35024) Related to milvus-io#34763 Signed-off-by: Congqi Xia <[email protected]> Signed-off-by: Sumit Dubey <[email protected]>
See also #34746
This PR add segment level field in response of
GetPersistentSegmentInfo
andGetQuerySegmentInfo