Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add Segment Level in milvus segment info APIs #34763

Merged

Conversation

congqixia
Copy link
Contributor

See also #34746

This PR add segment level field in response of GetPersistentSegmentInfo and GetQuerySegmentInfo

@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. area/dependency Pull requests that update a dependency file area/internal-api area/test sig/testing approved labels Jul 17, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jul 17, 2024
@congqixia congqixia force-pushed the enhance/add_level_for_segment_info branch from 414e68d to 49bb72b Compare July 23, 2024 10:43
See also milvus-io#34746

This PR add segment level field in response of `GetPersistentSegmentInfo`
and `GetQuerySegmentInfo`

Signed-off-by: Congqi Xia <[email protected]>
Signed-off-by: Congqi Xia <[email protected]>
Signed-off-by: Congqi Xia <[email protected]>
Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia force-pushed the enhance/add_level_for_segment_info branch from 13e3585 to 7a1aaea Compare July 24, 2024 19:02
Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Jul 24, 2024
Signed-off-by: Congqi Xia <[email protected]>
Signed-off-by: Congqi Xia <[email protected]>
@mergify mergify bot added the ci-passed label Jul 25, 2024
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.05%. Comparing base (a4d7da4) to head (9287986).
Report is 16 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #34763      +/-   ##
==========================================
- Coverage   80.95%   80.05%   -0.91%     
==========================================
  Files        1185     1190       +5     
  Lines      142758   143240     +482     
==========================================
- Hits       115569   114669     -900     
- Misses      22782    24155    +1373     
- Partials     4407     4416       +9     
Files Coverage Δ
internal/proxy/impl.go 86.25% <100.00%> (+<0.01%) ⬆️
internal/querycoordv2/utils/types.go 79.31% <100.00%> (+0.36%) ⬆️
internal/storage/serde.go 94.35% <100.00%> (ø)
internal/proxy/accesslog/info/grpc_info.go 96.47% <75.00%> (-1.34%) ⬇️

... and 124 files with indirect coverage changes

Copy link
Contributor

@XuanYang-cn XuanYang-cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 4ee6c69 into milvus-io:master Jul 26, 2024
11 of 12 checks passed
congqixia added a commit to congqixia/milvus that referenced this pull request Jul 26, 2024
See also milvus-io#34746

This PR add segment level field in response of
`GetPersistentSegmentInfo` and `GetQuerySegmentInfo`

---------

Signed-off-by: Congqi Xia <[email protected]>
congqixia added a commit to congqixia/milvus that referenced this pull request Jul 26, 2024
congqixia added a commit to congqixia/milvus that referenced this pull request Jul 26, 2024
sre-ci-robot pushed a commit that referenced this pull request Jul 26, 2024
sre-ci-robot pushed a commit that referenced this pull request Jul 29, 2024
…#35023)

Cherry-pick from master
pr: #34763
See also #34746

This PR add segment level field in response of
`GetPersistentSegmentInfo` and `GetQuerySegmentInfo`

---------

---------

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia deleted the enhance/add_level_for_segment_info branch July 30, 2024 02:33
sumitd2 pushed a commit to sumitd2/milvus that referenced this pull request Aug 6, 2024
See also milvus-io#34746

This PR add segment level field in response of
`GetPersistentSegmentInfo` and `GetQuerySegmentInfo`

---------

Signed-off-by: Congqi Xia <[email protected]>
Signed-off-by: Sumit Dubey <[email protected]>
sumitd2 pushed a commit to sumitd2/milvus that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependency Pull requests that update a dependency file area/internal-api area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants