-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: compaction task not be cleaned correctly #34765
Conversation
27b208b
to
2145815
Compare
@wayblink E2e jenkins job failed, comment |
rerun ut |
/run-cpu-e2e |
2145815
to
17db5ff
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wayblink, xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1.fix compaction task not be cleaned correctly 2.add a new parameter to control compaction gc loop interval 3.remove some useless configs of clustering compaction bug: #34764 pr: #34765 Signed-off-by: wayblink <[email protected]>
17db5ff
to
3fb3bc2
Compare
3fb3bc2
to
46fb472
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #34765 +/- ##
===========================================
- Coverage 80.98% 70.12% -10.87%
===========================================
Files 1189 1189
Lines 143345 143370 +25
===========================================
- Hits 116087 100535 -15552
- Misses 22835 38425 +15590
+ Partials 4423 4410 -13
|
46fb472
to
98fe80d
Compare
98fe80d
to
ad55eef
Compare
1.fix compaction task not be cleaned correctly 2.add a new parameter to control compaction gc loop interval 3.remove some useless configs of clustering compaction Signed-off-by: wayblink <[email protected]>
ad55eef
to
cef176e
Compare
/lgtm |
1.fix compaction task not be cleaned correctly 2.add a new parameter to control compaction gc loop interval 3.remove some useless configs of clustering compaction bug: milvus-io#34764 Signed-off-by: wayblink <[email protected]> Signed-off-by: Sumit Dubey <[email protected]>
1.fix compaction task not be cleaned correctly
2.add a new parameter to control compaction gc loop interval
3.remove some useless configs of clustering compaction
bug: #34764