fix: compaction task not be cleaned correctly #34765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27b208b
to
2145815
Compare
|
@wayblink E2e jenkins job failed, comment |
|
rerun ut |
|
/run-cpu-e2e |
2145815
to
17db5ff
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wayblink, xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sre-ci-robot
pushed a commit
that referenced
this pull request
Jul 17, 2024
1.fix compaction task not be cleaned correctly 2.add a new parameter to control compaction gc loop interval 3.remove some useless configs of clustering compaction bug: #34764 pr: #34765 Signed-off-by: wayblink <[email protected]>
17db5ff
to
3fb3bc2
Compare
3fb3bc2
to
46fb472
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #34765 +/- ##
===========================================
- Coverage 80.98% 70.12% -10.87%
===========================================
Files 1189 1189
Lines 143345 143370 +25
===========================================
- Hits 116087 100535 -15552
- Misses 22835 38425 +15590
+ Partials 4423 4410 -13
|
46fb472
to
98fe80d
Compare
98fe80d
to
ad55eef
Compare
1.fix compaction task not be cleaned correctly 2.add a new parameter to control compaction gc loop interval 3.remove some useless configs of clustering compaction Signed-off-by: wayblink <[email protected]>
ad55eef
to
cef176e
Compare
|
/lgtm |
sumitd2
pushed a commit
to sumitd2/milvus
that referenced
this pull request
Aug 6, 2024
1.fix compaction task not be cleaned correctly 2.add a new parameter to control compaction gc loop interval 3.remove some useless configs of clustering compaction bug: milvus-io#34764 Signed-off-by: wayblink <[email protected]> Signed-off-by: Sumit Dubey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.fix compaction task not be cleaned correctly
2.add a new parameter to control compaction gc loop interval
3.remove some useless configs of clustering compaction
bug: #34764