-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: Remove useless ops when there is no write #34767
enhance: Remove useless ops when there is no write #34767
Conversation
Related to milvus-io#33235 THe querynode pipeline will make map & call ProcessInsert when there is no write messages. So querynodes will have high CPU usage even when there is no workload. This PR check msg length before composing data struct and calling method Signed-off-by: Congqi Xia <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #34767 +/- ##
==========================================
+ Coverage 80.76% 84.39% +3.62%
==========================================
Files 1161 891 -270
Lines 141018 116823 -24195
==========================================
- Hits 113898 98588 -15310
+ Misses 22755 13856 -8899
- Partials 4365 4379 +14
|
/lgtm |
Related to milvus-io#33235 THe querynode pipeline will make map & call ProcessInsert when there is no write messages. So querynodes will have high CPU usage even when there is no workload. This PR check msg length before composing data struct and calling method Signed-off-by: Congqi Xia <[email protected]>
Related to milvus-io#33235 THe querynode pipeline will make map & call ProcessInsert when there is no write messages. So querynodes will have high CPU usage even when there is no workload. This PR check msg length before composing data struct and calling method Signed-off-by: Congqi Xia <[email protected]>
Related to milvus-io#33235 THe querynode pipeline will make map & call ProcessInsert when there is no write messages. So querynodes will have high CPU usage even when there is no workload. This PR check msg length before composing data struct and calling method Signed-off-by: Congqi Xia <[email protected]>
…4839) Cherry pick from master pr: #34767 Related to: #33235 THe querynode pipeline will make map & call ProcessInsert when there is no write messages. So querynodes will have high CPU usage even when there is no workload. This PR check msg length before composing data struct and calling method Signed-off-by: Congqi Xia <[email protected]>
Related to #33235
THe querynode pipeline will make map & call ProcessInsert when there is no write messages. So querynodes will have high CPU usage even when there is no workload.
This PR check msg length before composing data struct and calling method