Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [skip e2e] effective way to use cache #34774

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

yellow-shine
Copy link
Collaborator

@yellow-shine yellow-shine commented Jul 17, 2024

issue: #34876

  1. try best to download cache
  2. upload cache if it is not pull request

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jul 17, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Jul 17, 2024
1. try best to download cache
2. upload cache if it is not pull request

Signed-off-by: Yellow Shine <[email protected]>
Copy link
Contributor

mergify bot commented Jul 17, 2024

@yellow-shine Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link

codecov bot commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.74%. Comparing base (17c96e1) to head (b531880).
Report is 42 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #34774      +/-   ##
==========================================
- Coverage   80.76%   80.74%   -0.03%     
==========================================
  Files        1161     1161              
  Lines      141018   141120     +102     
==========================================
+ Hits       113898   113951      +53     
- Misses      22755    22798      +43     
- Partials     4365     4371       +6     

see 23 files with indirect coverage changes

@yellow-shine yellow-shine changed the title feat: effective way to use cache feat: [skip e2e] effective way to use cache Jul 22, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, yellow-shine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yellow-shine yellow-shine added the kind/enhancement Issues or changes related to enhancement label Jul 23, 2024
@mergify mergify bot added the ci-passed label Jul 23, 2024
@sre-ci-robot sre-ci-robot merged commit 1f55061 into milvus-io:master Jul 23, 2024
10 checks passed
sre-ci-robot pushed a commit that referenced this pull request Jul 23, 2024
yellow-shine added a commit to yellow-shine/milvus that referenced this pull request Jul 30, 2024
sre-ci-robot pushed a commit that referenced this pull request Jul 30, 2024
yellow-shine added a commit to yellow-shine/milvus that referenced this pull request Aug 2, 2024
yellow-shine added a commit to yellow-shine/milvus that referenced this pull request Aug 2, 2024
yellow-shine added a commit to yellow-shine/milvus that referenced this pull request Aug 2, 2024
issue: milvus-io#34876
1. try best to download cache
2. upload cache if it is not pull request

Signed-off-by: Yellow Shine <[email protected]>
yellow-shine added a commit to yellow-shine/milvus that referenced this pull request Aug 2, 2024
yellow-shine added a commit to yellow-shine/milvus that referenced this pull request Aug 2, 2024
sumitd2 pushed a commit to sumitd2/milvus that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement kind/feature Issues related to feature request from users lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants