enhance: [2.4] add scalar filtering and vector search latency metrics #34783
Conversation
|
@foxspy Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”) |
|
pr: #34785 |
|
rerun ut |
be4b656
to
2f73ac6
Compare
2f73ac6
to
eaac86d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.4 #34783 +/- ##
==========================================
+ Coverage 81.15% 81.19% +0.04%
==========================================
Files 786 786
Lines 112864 112871 +7
==========================================
+ Hits 91593 91648 +55
+ Misses 16872 16827 -45
+ Partials 4399 4396 -3 |
| vector_end - scalar_start) | ||
| .count(); | ||
| double scalar_ratio = total_cost > 0.0 ? scalar_cost * 100.0 / total_cost : 0.0; | ||
| monitor::internal_core_search_latency_scalar_proportion.Observe( |
There was a problem hiding this comment.
The internal_core_search_latency_scalar_proportion is always a value between 0-100.
but the default bucket of internal_core_search_latency_scalar_proportion histogram is 1 - 65535.
So it's better to use DEFINE_PROMETHEUS_HISTOGRAM_WITH_BUCKETS to change the bucket into a fit one.
eaac86d
to
84a701a
Compare
|
@foxspy E2e jenkins job failed, comment |
Signed-off-by: xianliang.li <[email protected]>
84a701a
to
43d82be
Compare
|
@foxspy E2e jenkins job failed, comment |
|
/run-e2e |
|
/run-cpu-e2e |
|
/lgtm |
|
|
||
| vector<string> | ||
| split(const string& str, | ||
| const string& delim) { //将分割后的子字符串存储在vector中 |
There was a problem hiding this comment.
Just moved from test_storage.cpp...
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, foxspy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
issue: #34780
pr: #34785