Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: record the duration waiting in the proxy queue (#34744) #34788

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

longjiquan
Copy link
Contributor

fix: #34743
pr: #34744

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jul 18, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Jul 18, 2024
Signed-off-by: longjiquan <[email protected]>
@mergify mergify bot added the ci-passed label Jul 18, 2024
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 93.80531% with 7 lines in your changes missing coverage. Please review.

Project coverage is 81.18%. Comparing base (0e22650) to head (f778b51).
Report is 2 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #34788      +/-   ##
==========================================
+ Coverage   81.15%   81.18%   +0.03%     
==========================================
  Files         786      786              
  Lines      112871   112902      +31     
==========================================
+ Hits        91602    91665      +63     
+ Misses      16869    16829      -40     
- Partials     4400     4408       +8     
Files Coverage Δ
internal/proxy/task.go 88.87% <100.00%> (+1.42%) ⬆️
internal/proxy/task_alias.go 95.83% <100.00%> (ø)
internal/proxy/task_database.go 96.68% <100.00%> (+2.20%) ⬆️
internal/proxy/task_delete.go 92.41% <100.00%> (+0.08%) ⬆️
internal/proxy/task_index.go 82.91% <100.00%> (+2.32%) ⬆️
internal/proxy/task_scheduler.go 95.42% <100.00%> (+0.07%) ⬆️
internal/proxy/task_search.go 76.83% <ø> (+0.31%) ⬆️
internal/proxy/task_statistic.go 84.66% <100.00%> (+1.76%) ⬆️
pkg/metrics/proxy_metrics.go 73.68% <0.00%> (-0.56%) ⬇️
internal/proxy/task_insert.go 76.78% <50.00%> (+0.56%) ⬆️
... and 2 more

... and 17 files with indirect coverage changes

@czs007
Copy link
Contributor

czs007 commented Jul 19, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, longjiquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 34873a7 into milvus-io:2.4 Jul 19, 2024
11 of 12 checks passed
@longjiquan longjiquan deleted the proxy-queue-metric-24 branch July 19, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/feature Issues related to feature request from users lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants