Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: record the duration waiting in the proxy queue (#34744) #34791

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

longjiquan
Copy link
Contributor

fix: #34743
pr: #34744

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jul 18, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Jul 18, 2024
Copy link
Contributor

mergify bot commented Jul 18, 2024

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@longjiquan
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Jul 18, 2024

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
Copy link
Contributor

mergify bot commented Jul 18, 2024

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@longjiquan
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Jul 18, 2024

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
Copy link
Contributor

mergify bot commented Jul 18, 2024

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jul 18, 2024

@longjiquan ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented Jul 18, 2024

@longjiquan ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented Jul 18, 2024

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jul 19, 2024

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@longjiquan
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Jul 19, 2024

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jul 19, 2024

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@longjiquan
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Jul 19, 2024

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@longjiquan
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Jul 19, 2024

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: longjiquan <[email protected]>
Copy link
Contributor

mergify bot commented Jul 19, 2024

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@longjiquan
Copy link
Contributor Author

/run-cpu-e2e

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 94.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 83.14%. Comparing base (3d9ec2a) to head (5c7f324).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #34791      +/-   ##
==========================================
+ Coverage   83.11%   83.14%   +0.02%     
==========================================
  Files         851      851              
  Lines      107186   107217      +31     
==========================================
+ Hits        89085    89141      +56     
+ Misses      14785    14750      -35     
- Partials     3316     3326      +10     
Files Coverage Δ
internal/proxy/task.go 88.87% <100.00%> (+1.43%) ⬆️
internal/proxy/task_alias.go 95.83% <100.00%> (ø)
internal/proxy/task_database.go 100.00% <ø> (ø)
internal/proxy/task_delete.go 87.43% <100.00%> (+0.14%) ⬆️
internal/proxy/task_index.go 82.31% <100.00%> (+2.35%) ⬆️
internal/proxy/task_scheduler.go 95.22% <100.00%> (+0.08%) ⬆️
internal/proxy/task_search.go 78.77% <ø> (+0.33%) ⬆️
internal/proxy/task_statistic.go 84.66% <100.00%> (+1.76%) ⬆️
pkg/metrics/proxy_metrics.go 100.00% <100.00%> (ø)
internal/proxy/task_insert.go 71.16% <50.00%> (+0.72%) ⬆️
... and 2 more

... and 13 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jul 19, 2024
@czs007 czs007 added this to the 2.3.20 milestone Jul 19, 2024
@czs007
Copy link
Contributor

czs007 commented Jul 19, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, longjiquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 08c6ab8 into milvus-io:2.3 Jul 19, 2024
11 of 12 checks passed
@longjiquan longjiquan deleted the proxy-queue-metric-23 branch July 19, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/feature Issues related to feature request from users lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants