Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added embroider-safe and embroider-optimized to the test scenarios #2184

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cah-brian-gantzler
Copy link
Collaborator

No description provided.

@thoov
Copy link

thoov commented May 18, 2021

@cah-briangantzler in the next release of Embroider we will handle the webpack dependency within the helpers so that dep does not need to be explicitly set. So it might be worth waiting for that

@cah-brian-gantzler
Copy link
Collaborator Author

Good to know. Since the change was just made to require the app to do the webpack, I should have just added webpack as a devDependancy instead of what I did and figured that was the desired direction.

@rahulk94
Copy link
Contributor

Oh nice to see this is already raised @cah-briangantzler. If ya upgrade your dependency of the @embroider/test-setup to the latest now you should be able update remove the explicit webpack handling as @thoov mentioned earlier 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants