-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Link Toolpad core docs to the docs menu #42952
[docs] Link Toolpad core docs to the docs menu #42952
Conversation
Netlify deploy previewhttps://deploy-preview-42952--material-ui.netlify.app/ Bundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we were doing "Toolpad core" and "Toolpad Studio", but no strong opinion here.
Not ready to merge until ready on Toolpad side.
Marija mentioned that Core team has dropped 'Core', so we could use it here. Also having Toolpad in the title helps us keep the overall section less wordy and uses a single Beta badge. So I have kept it like this. |
That could be a reason to keep "Toolpad Core" as to minimize confusion with existing users that conotate "Core" with "MUI core" still.
The icon you imported has some internal padding that the original doesn't have. To keep in line with the other icons we perhaps we could pick something we can assign color to? Perhaps there are existing icons that would suit us well? |
Added Toolpad to the product names, it appears to look fine. 👍
As it would mean changing Toolpad Studio icon at multiple other places. I'll bring this up in our next discussion. |
Co-authored-by: Jan Potoms <[email protected]> Signed-off-by: Prakhar Gupta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but to be merged once Toolpad landing page is ready
There would be a Logo mismatch in this scenario - The new logo of Toolpad Core isn't the blocks one. Options:
|
My first thought was option 2, I guess that should be good if we're still using the blocks logo? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No more changes needed here either I think.
That are the toolpad docs, you need to look at the Material UI docs |
Got it. Thanks. I think we can merge it. |
Preview: https://deploy-preview-42952--material-ui.netlify.app/
Toolpad core linked in the Docs menu:
To fix