Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common)!: type narrowing allowed injection tokens for @Inject() #12735

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

micalevisk
Copy link
Member

@micalevisk micalevisk commented Nov 13, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

we can pass anything to @Inject() decorator factory

What is the new behavior?

now we can only pass injection tokens (same type for provide on custom providers)

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@micalevisk micalevisk changed the title feat(common): narrow allowed injection tokens for @Inject() feat(common): type narrowing allowed injection tokens for @Inject() Nov 13, 2023
@micalevisk micalevisk closed this Nov 14, 2023
@micalevisk micalevisk reopened this Nov 14, 2023
@coveralls
Copy link

coveralls commented Nov 14, 2023

Pull Request Test Coverage Report for Build d82035ec-2bea-47c6-8b34-fa7bc99f4aea

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.26%

Totals Coverage Status
Change from base Build e7c88d17-2198-4c13-b01a-98aa728736b6: 0.0%
Covered Lines: 6687
Relevant Lines: 7248

💛 - Coveralls

@Tony133
Copy link
Contributor

Tony133 commented Nov 14, 2023

screen

@micalevisk micalevisk changed the title feat(common): type narrowing allowed injection tokens for @Inject() feat(common)!: type narrowing allowed injection tokens for @Inject() Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants