Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(sample-12): added unit and e2e tests #12790

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

pacyL2K19
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other: Added unit and e2e tests to the sample-12

What is the current behavior?

Issue Number: #1539

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

I have added unit and e2e tests to the sample-12-graphql-schema-first
Increased the test coverage
This is my first contribution to the project, I may miss a couple of things, I will appreciate any feedback

@coveralls
Copy link

coveralls commented Nov 23, 2023

Pull Request Test Coverage Report for Build 80567a20-17a5-4037-8fd1-f2a66e07e4f6

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.258%

Totals Coverage Status
Change from base Build 07271e8a-a67e-47df-be5c-241b54a18b75: 0.0%
Covered Lines: 6697
Relevant Lines: 7259

💛 - Coveralls

@pacyL2K19 pacyL2K19 force-pushed the test/sample-12-graphql-schema-first branch from a87827f to 758e8f0 Compare November 23, 2023 10:07
@pacyL2K19 pacyL2K19 force-pushed the test/sample-12-graphql-schema-first branch from 758e8f0 to 86826a6 Compare November 25, 2023 17:13
@pacyL2K19
Copy link
Author

@micalevisk fixed the conflicts by rebasing with nest:master, please have a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants