-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: emit batch #12954
base: master
Are you sure you want to change the base?
feat: emit batch #12954
Conversation
Pull Request Test Coverage Report for Build d4f0316f-3bf4-4a53-b632-eebbc32fa552Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the rest it seems ok 👍
async dispatchBatchEvent<TInput = any>( | ||
packets: ReadPacket<{ messages: TInput[] }>, | ||
): Promise<any> { | ||
if (packets.data.messages.length === 0) return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (packets.data.messages.length === 0) return; | |
if (packets.data.messages.length === 0) { | |
return; | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would love to see this feature merged. Very handy for our use-case. |
@kamilmysliwiec Is this going to be merged, and if so, do you have any estimates for when? And another thing, are you open to batching now? You said no here, #9455 |
hi all, pls consider this PR |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #12748
What is the new behavior?
enable kafka producer to emit batch
Does this PR introduce a breaking change?
Other information