Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(microservices): added MqttOption for passing raw output to pub #8972

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

notusertelken
Copy link

@notusertelken notusertelken commented Jan 20, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

mqtt-server and client stringify the output of the serializer before emitting/publishing events

Issue Number: 7288

What is the new behavior?

moved JSON.stringify to the serializer, so now the output of the serializer goes directly into publish/emit.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

coveralls commented Jan 20, 2022

Pull Request Test Coverage Report for Build 6fa77dde-eb4c-4a5b-aab8-98160be3959b

  • 14 of 14 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 94.135%

Totals Coverage Status
Change from base Build 030c7bfc-7fd6-457a-8c24-3f90c6cb9edf: 0.005%
Covered Lines: 5698
Relevant Lines: 6053

💛 - Coveralls

@notusertelken
Copy link
Author

If this implementation is found acceptable, ill shortly make PRs for the other transport servers

@kamilmysliwiec
Copy link
Member

@notusertelken looks good!

@notusertelken
Copy link
Author

had forgotten about the client 😅

@Clex1o1
Copy link

Clex1o1 commented Apr 26, 2022

Here is also a string transformation of the payload. Shouldn't it be possible to use raw format too?

const rawPacket = this.parseMessage(buffer.toString());

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants