-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(microservices): added MqttOption for passing raw output to pub #8972
Open
notusertelken
wants to merge
6
commits into
nestjs:master
Choose a base branch
from
notusertelken:feature/mqtt-raw-output
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(microservices): added MqttOption for passing raw output to pub #8972
notusertelken
wants to merge
6
commits into
nestjs:master
from
notusertelken:feature/mqtt-raw-output
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 6fa77dde-eb4c-4a5b-aab8-98160be3959b
💛 - Coveralls |
micalevisk
reviewed
Jan 20, 2022
packages/microservices/interfaces/microservice-configuration.interface.ts
Outdated
Show resolved
Hide resolved
If this implementation is found acceptable, ill shortly make PRs for the other transport servers |
@notusertelken looks good! |
had forgotten about the client 😅 |
Here is also a string transformation of the payload. Shouldn't it be possible to use raw format too?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
mqtt-server and client stringify the output of the serializer before emitting/publishing events
Issue Number: 7288
What is the new behavior?
moved JSON.stringify to the serializer, so now the output of the serializer goes directly into publish/emit.
Does this PR introduce a breaking change?
Other information