Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/googlecloudmonitoringreceiver] Adding Google Cloud monitoring receiver #34015

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

[receiver/googlecloudmonitoringreceiver] Adding Google Cloud monitoring receiver #34015

wants to merge 14 commits into from

Conversation

abhishek-at-cloudwerx
Copy link

Description: Adding Google Cloud Monitoring receiver

Link to tracking Issue: #33762

Testing: Test cases for configuration added

Documentation: README file added for describing the component

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jul 10, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@abhishek-at-cloudwerx abhishek-at-cloudwerx force-pushed the googlecloudmonitoringreceiver-phase1 branch from dff685d to 97ff395 Compare July 10, 2024 09:11
@crobert-1
Copy link
Member

Hello @abhishek-at-cloudwerx, please sign the CLA to enable this PR to be reviewed.

@abhishek-at-cloudwerx
Copy link
Author

@crobert-1 - Yes we're working on getting the org CLA sorted. Unfortunately we are unable to get any help in figuring out who registered as Org admin.

@abhishek-at-cloudwerx abhishek-at-cloudwerx marked this pull request as ready for review July 19, 2024 05:47
@abhishek-at-cloudwerx abhishek-at-cloudwerx requested a review from a team as a code owner July 19, 2024 05:47
@abhishek-at-cloudwerx
Copy link
Author

@crobert-1 - The CLA is now signed and PR is ready for review.

@dashpole - Tagging as Sponsor
@TylerHelmuth - to be one of the CODEOWNERS

dashpole
dashpole reviewed Jul 19, 2024
View reviewed changes
.chloggen/googlecloudmonitoringreceiver-phase1.yaml Outdated Show resolved Hide resolved
cmd/otelcontribcol/go.mod Outdated Show resolved Hide resolved
receiver/googlecloudmonitoringreceiver/README.md Outdated Show resolved Hide resolved
receiver/googlecloudmonitoringreceiver/receiver.go Outdated Show resolved Hide resolved
receiver/googlecloudmonitoringreceiver/config.go Outdated Show resolved Hide resolved
receiver/googlecloudmonitoringreceiver/README.md Show resolved Hide resolved
receiver/googlecloudmonitoringreceiver/config.go Outdated Show resolved Hide resolved
receiver/googlecloudmonitoringreceiver/config.go Outdated Show resolved Hide resolved
receiver/googlecloudmonitoringreceiver/config.go Outdated Show resolved Hide resolved
receiver/googlecloudmonitoringreceiver/README.md Show resolved Hide resolved
@abhishek-at-cloudwerx
Refactor:
81bef25 
- Changes based on PR commits
@abhishek-at-cloudwerx
Copy link
Author

@dashpole I made the changes as per your comment and removed the service_name field since we now fetch details directly based on the metric_name.

@abhishek-at-cloudwerx
Refactor:
87ebf1e 
- Update test-cases based on config file
@abhishek-at-cloudwerx
Refactor:
f36102e 
- Update config name with test cases and readme.md file
@abhishek-at-cloudwerx
Merge branch 'main' into googlecloudmonitoringreceiver-phase1
1f340ef
@abhishek-at-cloudwerx
Refactor:
0bd6c9f 
- Update go version for googlecloudmonitoringreceiver component
@abhishek-at-cloudwerx
Merge branch 'main' into googlecloudmonitoringreceiver-phase1
5394935
dashpole
dashpole reviewed Jul 30, 2024
View reviewed changes
cmd/otelcontribcol/go.mod Outdated Show resolved Hide resolved
dashpole
dashpole reviewed Jul 30, 2024
View reviewed changes
cmd/oteltestbedcol/go.mod Outdated Show resolved Hide resolved
dashpole
dashpole approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after nits addressed

atoulme
atoulme approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after nits addressed, @TylerHelmuth should review as well

@abhishek-at-cloudwerx
Refactor:
157c3ea 
- Update README.md file and go version for test files
@abhishek-at-cloudwerx
Copy link
Author

@TylerHelmuth @dashpole - Could one of you help merge this ?
Thanks

TylerHelmuth
TylerHelmuth reviewed Aug 2, 2024
View reviewed changes
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at the failing CI

receiver/googlecloudmonitoringreceiver/config.go
return errors.New("field \"metric_name\" is required and cannot be empty for metric configuration")
}

if metric.Delay < 0 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is a value of 0 ok?

Copy link
Author

@abhishek-at-cloudwerx abhishek-at-cloudwerx Aug 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this validation is intended to reject negative values only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrutimantri shrutimantri shrutimantri approved these changes

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

@dashpole dashpole Awaiting requested review from dashpole

@atoulme atoulme Awaiting requested review from atoulme

@TylerHelmuth TylerHelmuth Awaiting requested review from TylerHelmuth

Assignees

@mwear mwear

Labels
cmd/otelcontribcol otelcontribcol command cmd/oteltestbedcol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@abhishek-at-cloudwerx @crobert-1 @atoulme @dashpole @shrutimantri @TylerHelmuth @mwear