-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[testbed]Fix incorrect sent item count in ProviderSender #34061
Conversation
# Include 'user' if the change is relevant to end users. | ||
# Include 'api' if there is a change to a library API. | ||
# Default: '[user]' | ||
change_logs: [user] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[For reviewers] I am not entirely sure if it requires a changelog OR if the changelog should be user
. Based on the contributing guidelines, the change fixes a bug in the exposed API so I have added it as user
. CMIIW.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
usually it wouldn't be, but since testbed is itself considered a tool the project makes available to users, we would in this case add a changelog imo.
Description: Fixes incorrect data item sent count due to stopping the load generator.
Link to tracking Issue: Fixes #34057
Testing:
Run
cd testbed/testbed/ && while go test -v -count=1 -run=TestGeneratorAndBackend ./...; do :; done
for a satisfactory duration and ensure that there are no failures.Documentation: N/A