global error handling #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Summary
This PR introduces global error handling for both the main Electron process and the renderer process, improving error reporting and simplifying code structure.
- Added global error handling in
/electron/main/index.tsfor uncaught exceptions and unhandled rejections - Implemented renderer process error handling in
/src/main.tsxusingerrorToStringRendererProcessutility - Removed try-catch block around
ollamaService.init()in/electron/main/index.ts, potentially exposing unhandled initialization errors - Renamed functions for clarity:
electronUtilsHandlerstoregisterElectronUtilsHandlersandpathHandlerstoregisterPathHandlers - Simplified error handling logic in
/src/main.tsxby removing customhandleErrorfunction
4 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
| } catch (error) { | ||
| windowsManager.appendNewErrorToDisplayInWindow(errorToStringMainProcess(error)) | ||
| } | ||
| await ollamaService.init() |
There was a problem hiding this comment.
logic: Removing try-catch here may cause unhandled errors during ollamaService initialization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.