Editorial: Widen parameter type of CreateDynamicFunction #3380
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the current specification, type of the
newTarget
inCreateDynamicFunction
needs to be aconstructor
. However, there is the case thatnewTarget
is undefined as follows:When this code executes,
Function
callsCreateDynamicFunction
in third step as follows:In this situation, undefined is assigned to
NewTarget
. Therefore, type-mismatch occurs in the parameternewTarget
ofCreateDynamicFunction
. Therefore, I think that the parameter type of thenewTarget
should be widened into a constructor or undefined.