Convert more "queue a task" to "queue an element task" #5432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust the last remaining element/node based references. The rest of the references in the spec are either document or global objects which will come in another CL. Part of whatwg#4980.
domenic
reviewed
Apr 7, 2020
| <li><p>Otherwise, <span>queue a task</span> on the <span>user interaction task source</span> | ||
| provided the <span>surrounding agent</span>'s <span data-x="concept-agent-event-loop">event | ||
| loop</span> to invoke <var>callback</var>, passing the actual data of the item represented by the | ||
| <code>DataTransferItem</code> object as the argument.</p></li> |
There was a problem hiding this comment.
For cases where the event loop is just the surrounding agent's event loop, I'd rather have this done centrally in the definition of "queue a task", instead of doing it at every call site.
| @@ -57581,7 +57582,8 @@ o............A....e | |||
| <li><p><span data-x="parse a url">Parse</span> <var>src</var> relative to the element's | |||
| <span>node document</span>.</p></li> | |||
|
|
|||
| <li><p>If the previous step failed, <span>queue a task</span> to <span | |||
| <li><p>If the previous step failed, <span>queue an element task</span> on the <span>DOM | |||
| manipulation task source</span> given the <code>script</code> element to <span | |||
There was a problem hiding this comment.
For these two, the networking task source seems more likely to be correct, since it would be aligned with the tasks queued if we had a fetch failure. That also aligns with the behavior for link and style (although not img). What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the last remaining element/node based references. The
rest of the references in the spec are either document or global objects
which will come in another CL.
Part of #4980.
💥 Error: Wattsi server error 💥
PR Preview failed to build. (Last tried on Jan 15, 2021, 7:59 AM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Wattsi Server - Wattsi Server is the web service used to build the WHATWG HTML spec.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.