Check BroadcastChannel origin against creation-time current #5729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...instead of against the creation-time incumbent. This helps with #1430, and allows a good amount of simplification as we no longer have to track the "BroadcastChannel settings object" separately from the relevant settings object. This also modernizes and cleans up the BroadcastChannel section editorially.
|
@bakulf thoughts? Seems reasonable to me. |
|
Yeah, it seems reasonable to me too. |
annevk
approved these changes
Jul 13, 2020
domenic
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 14, 2020
18 tasks
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jul 18, 2020
…ct is current, not incumbent, a=testonly Automatic update from web-platform-tests Test that BroadcastChannel settings object is current, not incumbent Follows whatwg/html#5729. -- wpt-commits: 74b3f3fcff249affad48bb1bfadf8877154a0f18 wpt-pr: 24568
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Jul 18, 2020
…ct is current, not incumbent, a=testonly Automatic update from web-platform-tests Test that BroadcastChannel settings object is current, not incumbent Follows whatwg/html#5729. -- wpt-commits: 74b3f3fcff249affad48bb1bfadf8877154a0f18 wpt-pr: 24568
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...instead of against the creation-time incumbent. This helps with
#1430, and allows a good amount of simplification as we no longer have
to track the "BroadcastChannel settings object" separately from the
relevant settings object.
This also modernizes and cleans up the BroadcastChannel section
editorially.
(See WHATWG Working Mode: Changes for more details.)
@annevk, any thoughts on who to ask at Mozilla about simplifying this in Firefox?
/web-messaging.html ( diff )