-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(next): update .astro paths #11963
base: next
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is blocked because it contains a major
changeset. A reviewer will merge this at the next release if approved.
For language-tools this mean that we need to load from multiple paths, here https://github.com/withastro/language-tools/blob/b79ff829224838492fcdfa273a03316863e724da/packages/ts-plugin/src/index.ts#L12 and here https://github.com/withastro/language-tools/blob/b79ff829224838492fcdfa273a03316863e724da/packages/language-server/src/nodeServer.ts#L45 |
Done in withastro/language-tools#951 |
Why are we moving all the files one-level down? Don't we control |
ATM we can't control where people put stuff. I'm in favor of creating somle kind of convention ( |
Do we want to say that it's safe to put your stuff in Astro owns the For |
It makes sense to me, as an integration author, to want to put codegen files in there since that's where astro does it. otherwise, that means you need to create your own As for the rest, I get your point, I guess we could move things outside of |
I think it's fine for integrations to put stuff into For |
Doesn't have to be in the beta so not urgent to answer. @Princesseuh when you have some time I'd like your opinion on that |
I don't see a big need for the PR to be done now, as it seems very unlikely for integrations to conflict with our files. Perhaps in the future if we see a lot of code gen being done. I think this can also somewhat be done in a non-breaking way? It's only the JSON schemas that are breaking I'm personally in favour of a dedicated |
Alright then if you're both okay with that, I'll do the following:
But yeah it doesn't have to be a 5.0 thing |
Changes
.astro/astro
.astro
dir? I feel like that should live in the cache dir insteadTesting
Should still pass
Docs
Not sure what should be updated. Pretty much everything should not be accessed directly by user, except json schemas for data collections. @sarah11918 would that only require updating https://docs.astro.build/en/guides/content-collections/#enabling-json-schema-generation ?