Details
-
Bug
-
Status: Resolved
-
P1
-
Resolution: Fixed
-
2.20.0
-
None
Description
I was checking today a pipeline against the latest 2.20.0-SNAPSHOT and I found that it works perfectly with version 2.19.0, but it is failing with a shade related exception that refers to grpc 1.26.0:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-shade-plugin:3.2.1:shade (default) on project EventsToIOs: Error creating shaded jar: Problem shading JAR /home/ismael/.m2/repository/org/apache/beam/beam-vendor-grpc-1_26_0/0.1/beam-vendor-grpc-1_26_0-0.1.jar entry org/apache/beam/vendor/grpc/v1p26p0/org/jboss/modules/Main.class: org.apache.maven.plugin.MojoExecutionException: Error in ASM processing class org/apache/beam/vendor/grpc/v1p26p0/org/jboss/modules/Main.class: 65536 -> [Help 1]
There is also a warning that is not present in the build against 2.19.0
[WARNING] Discovered module-info.class. Shading will break its strong encapsulation.
I wonder if we are not doing something wrong during our vendoring, can someone take a look please.
This is relatively easy to reproduce with the beam-samples repo, just clone it and run:
git clone https://github.com/jbonofre/beam-samples mvn clean verify -Pbeam-release-repo -Dbeam.version=2.20.0-SNAPSHOT
Available logs of the latest run:
https://github.com/jbonofre/beam-samples/runs/427537544?check_suite_focus=true
Attachments
Attachments
Issue Links
- is related to
-
BEAM-9030 Bump grpc to 1.26.0
- Resolved
- links to