Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Proto columns #1991

Merged
merged 19 commits into from
May 15, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into proto-column-enhancement-alpha
  • Loading branch information
harshachinta committed May 7, 2024
commit b3f9b13e0289f6d534b214f656ca4f4a0efd1dfe
Original file line number Diff line number Diff line change
Expand Up @@ -573,24 +573,21 @@ message CreateDatabaseRequest {
// Optional. The dialect of the Cloud Spanner Database.
DatabaseDialect database_dialect = 5 [(google.api.field_behavior) = OPTIONAL];

// Proto descriptors used by CREATE/ALTER PROTO BUNDLE statements in
// Optional. Proto descriptors used by CREATE/ALTER PROTO BUNDLE statements in
// 'extra_statements' above.
// Contains a protobuf-serialized
// [google.protobuf.FileDescriptorSet](https://github.com/protocolbuffers/protobuf/blob/main/src/google/protobuf/descriptor.proto).
// To generate it, [install](https://grpc.io/docs/protoc-installation/) and
// run `protoc` with --include_imports and --descriptor_set_out. For example,
// to generate for moon/shot/app.proto, run
// """
// ```
// $protoc --proto_path=/app_path --proto_path=/lib_path \
// --include_imports \
// --descriptor_set_out=descriptors.data \
// moon/shot/app.proto
// """
// ```
// For more details, see protobuffer [self
// description](https://developers.google.com/protocol-buffers/docs/techniques#self-description).
// (--
// TODO(b/236424835) remove visibility check before launch.
// --)
bytes proto_descriptors = 6 [(google.api.field_behavior) = OPTIONAL];
}

Expand Down Expand Up @@ -695,24 +692,20 @@ message UpdateDatabaseDdlRequest {
// `ALREADY_EXISTS`.
string operation_id = 3;

// Proto descriptors used by CREATE/ALTER PROTO BUNDLE statements in
// 'extra_statements' above.
// Optional. Proto descriptors used by CREATE/ALTER PROTO BUNDLE statements.
// Contains a protobuf-serialized
// [google.protobuf.FileDescriptorSet](https://github.com/protocolbuffers/protobuf/blob/main/src/google/protobuf/descriptor.proto).
// To generate it, [install](https://grpc.io/docs/protoc-installation/) and
// run `protoc` with --include_imports and --descriptor_set_out. For example,
// to generate for moon/shot/app.proto, run
// """
// ```
// $protoc --proto_path=/app_path --proto_path=/lib_path \
// --include_imports \
// --descriptor_set_out=descriptors.data \
// moon/shot/app.proto
// """
// ```
// For more details, see protobuffer [self
// description](https://developers.google.com/protocol-buffers/docs/techniques#self-description).
// (--
// TODO(b/236424835) remove visibility check before launch.
// --)
bytes proto_descriptors = 4 [(google.api.field_behavior) = OPTIONAL];
}

Expand Down Expand Up @@ -808,9 +801,6 @@ message GetDatabaseDdlResponse {
// [google.protobuf.FileDescriptorSet](https://github.com/protocolbuffers/protobuf/blob/main/src/google/protobuf/descriptor.proto).
// For more details, see protobuffer [self
// description](https://developers.google.com/protocol-buffers/docs/techniques#self-description).
// (--
// TODO(b/236424835) remove visibility check before launch.
// --)
bytes proto_descriptors = 2;
}

Expand Down
8 changes: 5 additions & 3 deletions protos/google/spanner/v1/type.proto
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,11 @@ message Type {
// affect serialization) and clients can ignore it on the read path.
TypeAnnotationCode type_annotation = 4;

// If [code][] == [PROTO][TypeCode.PROTO] or [code][] ==
// [ENUM][TypeCode.ENUM], then `proto_type_fqn` is the fully qualified name of
// the proto type representing the proto/enum definition.
// If [code][google.spanner.v1.Type.code] ==
// [PROTO][google.spanner.v1.TypeCode.PROTO] or
// [code][google.spanner.v1.Type.code] ==
// [ENUM][google.spanner.v1.TypeCode.ENUM], then `proto_type_fqn` is the fully
// qualified name of the proto type representing the proto/enum definition.
string proto_type_fqn = 5;
}

Expand Down
2,689 changes: 0 additions & 2,689 deletions protos/protos.d.ts

Large diffs are not rendered by default.

1,218 changes: 6 additions & 1,212 deletions protos/protos.js

Large diffs are not rendered by default.

Loading
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.